From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Kent Overstreet <kmo@daterainc.com>, Shaohua Li <shli@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] block: Eliminate first argument of submit_bio()
Date: Mon, 02 Jun 2014 10:04:37 -0600 [thread overview]
Message-ID: <538CA095.809@kernel.dk> (raw)
In-Reply-To: <538C4767.5050207@acm.org>
On 2014-06-02 03:44, Bart Van Assche wrote:
> The submit_bio() API is confusing. Merge functions like
> raid5_mergeable_bvec() can only work correctly if bi_rw is set
> before bio_add_page() has been called. submit_bio() modifies
> bi_rw after bio_add_page() has been called. Hence remove the
> first argument of submit_bio() and let the caller set bi_rw.
> Note: some but not all submit_bio() callers have been fixed
> such that bi_rw is set before bio_add_page() is called.
>
> See also http://thread.gmane.org/gmane.comp.file-systems.ocfs2.devel/7988
> for a prior discussion of this topic.
>
> Compile tested only, hence the "RFC".
It's a good cleanup, makes the API harder to misuse. The fact that rw
needs to be set before add_page() was a later addition, and we've
suffered from that.
Will need some testing, but after that should be good for 3.17.
--
Jens Axboe
prev parent reply other threads:[~2014-06-02 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 9:44 [PATCH RFC] block: Eliminate first argument of submit_bio() Bart Van Assche
2014-06-02 11:32 ` Christoph Hellwig
2014-06-02 16:04 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538CA095.809@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@infradead.org \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.