All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Hupp <grub-dev@prpcompany.com>
To: Andrey Borzenkov <arvidjaar@gmail.com>,
	 The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Grub2 theme bug with relative numeric values for boot_menu?
Date: Mon, 02 Jun 2014 12:06:03 -0400	[thread overview]
Message-ID: <538CA0EB.2030703@prpcompany.com> (raw)
In-Reply-To: <20140602175959.70ab0329@opensuse.site>

[-- Attachment #1: Type: text/plain, Size: 2692 bytes --]

On 6/2/2014 9:59 AM, Andrey Borzenkov wrote:
> В Mon, 26 May 2014 18:19:23 -0400
> John Hupp <grub-dev@prpcompany.com> пишет:
>
>> I'm trying to make my theme completely resolution-independent.  You can
>> see a current screen shot at Post your Grub 2 Themes
>> <http://ubuntuforums.org/showthread.php?t=1823915&page=14&p=13031738#post13031738>
>>
> Pictures are blocked for guests.

Thanks for replying.

Here it is:

>
>> Grub responded well to % values for the numeric values in the progress
>> bar and labels.  Also OK with %'s for boot_menu properties top, left,
>> height, width.
>>
>> But I'm getting bad behavior with item_height and the other properties.
>> For a 1024x768 grub display and an original setting of item_height = 26,
>> I can't get equivalent output unless I set item_height = 27%
>>
> These properties do not even understand proportional units. If you are
> using modified grub which adds support for it, please post patch,
> otherwise it is impossible to make any useful comment.

I did not know that these properties do not understand proportional 
units.  The documentation indicated that ALL numeric property values 
could be absolute or relative/proportional.  Regardless of that, I 
realized as I was working on it that unless relative value support 
extended to decimal values and not just integers, then I could not 
achieve what I was aiming for, because small values like item height, 
padding, etc., do not convert very precisely to integer percentages.

But even if there were support for decimal relative values, I also 
realized that I would have a problem getting equivalent displays under 
different screen aspect ratios.  This is especially true for icon height 
and width: an icon that is square under one aspect ratio would be 
rectangular under another.

So under the current grub scheme, we can make themes that are somewhat 
resolution-independent: the menu footprint and location, and label and 
progress bar locations will scale, but the menu items' properties must 
be absolute, meaning that they will be relatively large on some displays 
and small on others.  And I grant that this problem may be difficult to 
solve without adding a lot of code.

>
>> So item_height seems to be referencing a parent with a height of about
>> 96, rather than 768.
>>
>> This is in a VMWare Player environment running Lubuntu 14.04.
>>
>> Is this a known problem, or is there an explanation/workaround?
>>
>> (I also realized as I got into this that I will run into a problem with
>> different aspect ratios, so other than creating at least two themes for
>> the commonest aspect ratios, I'd be interested in a tip there as well if
>> there is a solution.)


[-- Attachment #2.1: Type: text/html, Size: 3983 bytes --]

[-- Attachment #2.2: ibggehgd.png --]
[-- Type: image/png, Size: 198161 bytes --]

  reply	other threads:[~2014-06-02 16:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26 22:19 Grub2 theme bug with relative numeric values for boot_menu? John Hupp
2014-06-02 13:59 ` Andrey Borzenkov
2014-06-02 16:06   ` John Hupp [this message]
2014-06-02 16:47     ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538CA0EB.2030703@prpcompany.com \
    --to=grub-dev@prpcompany.com \
    --cc=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.