From: Federico Di Pierro <nierro92@gmail.com>
To: jic23@kernel.org, jic23@kernel.org, gregkh@linuxfoundation.org,
jg1.han@samsung.com, sachin.kamat@linaro.org
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c
Date: Mon, 02 Jun 2014 19:05:01 +0200 [thread overview]
Message-ID: <538CAEBD.5040501@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 143 bytes --]
Hi!
This is my latest task of the eudyptula challenge.
Just a very small patch! It fixes 3 little coding style problems.
I'm using linux-next.
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1077 bytes --]
--- linux/drivers/staging/iio/frequency/ad9832.c.orig 2014-06-02 17:26:12.929978122 +0200
+++ linux/drivers/staging/iio/frequency/ad9832.c 2014-06-02 17:28:10.389970947 +0200
@@ -57,7 +57,7 @@ static int ad9832_write_frequency(struct
}
static int ad9832_write_phase(struct ad9832_state *st,
- unsigned long addr, unsigned long phase)
+ unsigned long addr, unsigned long phase)
{
if (phase > (1 << AD9832_PHASE_BITS))
return -EINVAL;
@@ -73,7 +73,7 @@ static int ad9832_write_phase(struct ad9
}
static ssize_t ad9832_write(struct device *dev,
- struct device_attribute *attr,
+ struct device_attribute *attr,
const char *buf,
size_t len)
{
@@ -109,11 +109,11 @@ static ssize_t ad9832_write(struct devic
ret = spi_sync(st->spi, &st->msg);
break;
case AD9832_FREQ_SYM:
- if (val == 1)
+ if (val == 1) {
st->ctrl_fp |= AD9832_FREQ;
- else if (val == 0)
+ } else if (val == 0) {
st->ctrl_fp &= ~AD9832_FREQ;
- else {
+ } else {
ret = -EINVAL;
break;
}
Signed-off-by: Federico Di Pierro <nierro92@gmail.org>
next reply other threads:[~2014-06-02 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 17:05 Federico Di Pierro [this message]
2014-06-02 17:14 ` [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c Joe Perches
2014-06-02 17:21 ` Jianyu Zhan
2014-06-02 17:44 ` Jonathan Cameron
2014-06-02 19:10 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538CAEBD.5040501@gmail.com \
--to=nierro92@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.