From: philippe.retornaz@gmail.com (Philippe Rétornaz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: imx: Use PTR_ERR_OR_ZERO in platform-mxc_rnga.c
Date: Mon, 02 Jun 2014 19:18:16 +0200 [thread overview]
Message-ID: <538CB1D8.5080809@gmail.com> (raw)
In-Reply-To: <20140529080321.GF8860@dragon>
Le 29/05/2014 10:03, Shawn Guo a ?crit :
> On Thu, May 29, 2014 at 10:27:10AM +0530, Sachin Kamat wrote:
>> PTR_ERR_OR_ZERO simplifies the code.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> ---
>> arch/arm/mach-imx/devices/platform-mxc_rnga.c | 6 ++---- 1 file
>> changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-imx/devices/platform-mxc_rnga.c
>> b/arch/arm/mach-imx/devices/platform-mxc_rnga.c index
>> [...]
>
> The existing code looks just fine and actually more readable to me.
> Also, all the files you are patching will eventually be killed by DT
> support. So let's just leave it there as it is for now.
heh ... well ... not so fast please !
There is a non-negligible amount of work to have a fully functional
imx31 on DT.
Not working:
- USB (chipidea driver sort of works, but the PHY is a complete mess).
- Camera
- SPI hardware chip select support
- pinmux support is totally absent
Currently, on imx31 we can boot on DT with (and only if the bootloader
does the pinmux for you):
- SDMA
- Watchdog
- SDHC
- Timer
- Uart
And I did not even had a look at the i2c, EMI, LCD and sound support.
So I hope imx31 platform boards can stay until the situation gets better.
Thanks,
Philippe
prev parent reply other threads:[~2014-06-02 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 4:57 [PATCH 1/5] ARM: imx: Use PTR_ERR_OR_ZERO in platform-mxc_rnga.c Sachin Kamat
2014-05-29 4:57 ` [PATCH 2/5] ARM: imx: Use PTR_ERR_OR_ZERO in mach-mx31moboard.c Sachin Kamat
2014-05-29 4:57 ` [PATCH 3/5] ARM: imx: Use PTR_ERR_OR_ZERO in mx31moboard-devboard.c Sachin Kamat
2014-05-29 4:57 ` [PATCH 4/5] ARM: imx: Use PTR_ERR_OR_ZERO in mx31moboard-marxbot.c Sachin Kamat
2014-05-29 4:57 ` [PATCH 5/5] ARM: imx: Use PTR_ERR_OR_ZERO in mx31moboard-smartbot.c Sachin Kamat
2014-05-29 8:03 ` [PATCH 1/5] ARM: imx: Use PTR_ERR_OR_ZERO in platform-mxc_rnga.c Shawn Guo
2014-05-29 8:06 ` Sachin Kamat
2014-06-02 17:18 ` Philippe Rétornaz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538CB1D8.5080809@gmail.com \
--to=philippe.retornaz@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.