From: Richard Henderson <rth@twiddle.net>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies
Date: Mon, 02 Jun 2014 11:13:07 -0700 [thread overview]
Message-ID: <538CBEB3.4090309@twiddle.net> (raw)
In-Reply-To: <1401709825-32579-1-git-send-email-kraxel@redhat.com>
On 06/02/2014 04:50 AM, Gerd Hoffmann wrote:
> @@ -1996,6 +1997,9 @@ if test "$gtk" != "no"; then
> gtk_libs=`$pkg_config --libs $gtkpackage`
> libs_softmmu="$gtk_libs $libs_softmmu"
> gtk="yes"
> + if $pkg_config --exists "$gtkx11package >= $gtkversion"; then
> + gtk_libs="$gtk_libs -lX11"
> + fi
You need to move this hunk above the libs_softmmu line,
otherwise the assignment is unused.
r~
next prev parent reply other threads:[~2014-06-02 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 11:50 [Qemu-devel] [PATCH] gtk: cleanup backend dependencies Gerd Hoffmann
2014-06-02 11:54 ` Daniel P. Berrange
2014-06-02 18:13 ` Richard Henderson [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-02 10:58 Gerd Hoffmann
2014-06-02 11:10 ` Daniel P. Berrange
2014-06-02 11:13 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538CBEB3.4090309@twiddle.net \
--to=rth@twiddle.net \
--cc=aliguori@amazon.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.