From: Thomas Wood <tommyandrena@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: marek.belisko@gmail.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ft1000: ft1000-usb: ft1000_debug.c: Fix style errors and some warnings.
Date: Mon, 02 Jun 2014 12:23:16 -0700 [thread overview]
Message-ID: <538CCF24.1030800@gmail.com> (raw)
In-Reply-To: <20140602103056.GY15585@mwanda>
On 06/02/2014 03:30 AM, Dan Carpenter wrote:
> On Sun, Jun 01, 2014 at 07:26:18PM -0700, Thomas Wood wrote:
>> Don't use spaces as tabs, and fix other style errors and warnings.
>>
>> Signed-off-by: Thomas Wood <tommyandrena@gmail.com>
>
> Too much in one patch. Break it up into one type of fix per patch and
> send a series of patches.
>
> [patch 1] use tabs
> [patch 2] fix braces style
> [patch 3] remove parens from return values
> [patch 4] reverse an if statement
>
> patch 3 and 4 are small enough that you could get away with pushing them
> into a single "misc fixes" patch and we wouldn't have complained but the
> first two patches are very big.
>
> regards,
> dan carpenter
>
>
Ah, thank you. I will do so.
next prev parent reply other threads:[~2014-06-02 19:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 2:26 [PATCH] staging: ft1000: ft1000-usb: ft1000_debug.c: Fix style errors and some warnings Thomas Wood
2014-06-02 10:30 ` Dan Carpenter
2014-06-02 19:23 ` Thomas Wood [this message]
2014-06-07 3:02 ` [PATCH v2 0/5] staging: ft1000: ft1000-usb: ft1000_debug.c: Fix style errors and warnings Thomas Wood
2014-06-07 3:02 ` [PATCH v2 1/5] staging: ft1000: ft1000-usb: ft1000_debug.c: Replace spaces with tabs Thomas Wood
2014-06-07 3:02 ` [PATCH v2 2/5] staging: ft1000: ft1000-usb: ft1000_debug.c: Add required spaces Thomas Wood
2014-06-07 3:02 ` [PATCH v2 3/5] staging: ft1000: ft1000-usb: ft1000_debug.c: Remove unnecessary whitespace Thomas Wood
2014-06-07 3:02 ` [PATCH v2 4/5] staging: ft1000: ft1000-usb: ft1000_debug.c: Remove unnecessary braces Thomas Wood
2014-06-07 3:02 ` [PATCH v2 5/5] staging: ft1000: ft1000-usb: ft1000_debug.c: Misc. fixes Thomas Wood
2014-06-09 7:16 ` Dan Carpenter
2014-06-20 0:01 ` Greg KH
2014-06-07 16:56 ` [PATCH v2 0/5] staging: ft1000: ft1000-usb: ft1000_debug.c: Fix style errors and warnings Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538CCF24.1030800@gmail.com \
--to=tommyandrena@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.