diff for duplicates of <538CDC08.7020106@ziswiler.com> diff --git a/a/1.txt b/N1/1.txt index d1a27d8..27c9190 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,21 +14,21 @@ If it is preferred having this as a separate commit I can ask Stefan to submit one once he returns from his vacation next week. >> diff --git a/arch/arm/boot/dts/tegra30-apalis-eval.dts b/arch/arm/boot/dts/tegra30-apalis-eval.dts ->> + host1x@50000000 { ->> + dc@54200000 { +>> + host1x at 50000000 { +>> + dc at 54200000 { >> + rgb { >> + status = "okay"; >> + nvidia,panel = <&panel>; >> + }; >> + }; ->> + hdmi@54280000 { +>> + hdmi at 54280000 { > > Nit: Add a blank line between the nodes. Check elsewhere too. Sure, I actually checked elsewhere as it is 1-to-1 how it got accepted for the Colibri T30. ->> + serial@70006040 { +>> + serial at 70006040 { >> + compatible = "nvidia,tegra30-hsuart"; >> + status = "okay"; >> + }; @@ -39,10 +39,10 @@ for the Colibri T30. Dito. >> + /* SPI1: Apalis SPI1 */ ->> + spi@7000d400 { +>> + spi at 7000d400 { >> + status = "okay"; >> + spi-max-frequency = <25000000>; ->> + spidev0: spidev@1 { +>> + spidev0: spidev at 1 { > > Nit: Add a blank line between properties and nodes. Check elsewhere too. @@ -51,9 +51,9 @@ Dito. Please excuse our ignorance. I will fix it and ask Stefan to do the same for the Colibri T30 DT. ->> + sd1: sdhci@78000000 { +>> + sd1: sdhci at 78000000 { > ... ->> + mmc1: sdhci@78000400 { +>> + mmc1: sdhci at 78000400 { > > Do those nodes really need labels? Nothing appears to reference them, > and I can't see why anything would. @@ -108,7 +108,7 @@ numbering which in this particular case turns out to be the opposite but makes us even more happy to comply. >> + regulators { ->> + sys_5v0_reg: regulator@1 { +>> + sys_5v0_reg: regulator at 1 { > > Nit: Why not start the numbering at 0? @@ -118,7 +118,7 @@ I guess starting with 100 resp. 0 might be more C programmer friendly. >> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi > ->> + pinmux@70000868 { +>> + pinmux at 70000868 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&state_default>; >> + diff --git a/a/content_digest b/N1/content_digest index 294e806..5b8db39 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,18 +1,10 @@ "ref\0c5522b0efcbfc7690dcde6aaf78b9dd568f99604.1401665237.git.marcel@ziswiler.com\0" "ref\0b470c9c8631a6ef021d140192eb07006de3cfd93.1401665237.git.marcel@ziswiler.com\0" "ref\0538CA5C3.5050709@wwwdotorg.org\0" - "ref\0538CA5C3.5050709-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org\0" - "From\0Marcel Ziswiler <marcel-mitwqZ+T+m9Wk0Htik3J/w@public.gmane.org>\0" - "Subject\0Re: [PATCH 3/3] arm: tegra: initial support for apalis t30\0" + "From\0marcel@ziswiler.com (Marcel Ziswiler)\0" + "Subject\0[PATCH 3/3] arm: tegra: initial support for apalis t30\0" "Date\0Mon, 02 Jun 2014 22:18:16 +0200\0" - "To\0Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>" - " thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org\0" - "Cc\0linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" - devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " stefan-XLVq0VzYD2Y@public.gmane.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On 06/02/2014 06:26 PM, Stephen Warren wrote:\n" @@ -31,21 +23,21 @@ "submit one once he returns from his vacation next week.\n" "\n" ">> diff --git a/arch/arm/boot/dts/tegra30-apalis-eval.dts b/arch/arm/boot/dts/tegra30-apalis-eval.dts\n" - ">> +\thost1x@50000000 {\n" - ">> +\t\tdc@54200000 {\n" + ">> +\thost1x at 50000000 {\n" + ">> +\t\tdc at 54200000 {\n" ">> +\t\t\trgb {\n" ">> +\t\t\t\tstatus = \"okay\";\n" ">> +\t\t\t\tnvidia,panel = <&panel>;\n" ">> +\t\t\t};\n" ">> +\t\t};\n" - ">> +\t\thdmi@54280000 {\n" + ">> +\t\thdmi at 54280000 {\n" ">\n" "> Nit: Add a blank line between the nodes. Check elsewhere too.\n" "\n" "Sure, I actually checked elsewhere as it is 1-to-1 how it got accepted \n" "for the Colibri T30.\n" "\n" - ">> +\tserial@70006040 {\n" + ">> +\tserial at 70006040 {\n" ">> +\t\tcompatible = \"nvidia,tegra30-hsuart\";\n" ">> +\t\tstatus = \"okay\";\n" ">> +\t};\n" @@ -56,10 +48,10 @@ "Dito.\n" "\n" ">> +\t/* SPI1: Apalis SPI1 */\n" - ">> +\tspi@7000d400 {\n" + ">> +\tspi at 7000d400 {\n" ">> +\t\tstatus = \"okay\";\n" ">> +\t\tspi-max-frequency = <25000000>;\n" - ">> +\t\tspidev0: spidev@1 {\n" + ">> +\t\tspidev0: spidev at 1 {\n" ">\n" "> Nit: Add a blank line between properties and nodes. Check elsewhere too.\n" "\n" @@ -68,9 +60,9 @@ "Please excuse our ignorance. I will fix it and ask Stefan to do the same \n" "for the Colibri T30 DT.\n" "\n" - ">> +\tsd1: sdhci@78000000 {\n" + ">> +\tsd1: sdhci at 78000000 {\n" "> ...\n" - ">> +\tmmc1: sdhci@78000400 {\n" + ">> +\tmmc1: sdhci at 78000400 {\n" ">\n" "> Do those nodes really need labels? Nothing appears to reference them,\n" "> and I can't see why anything would.\n" @@ -125,7 +117,7 @@ "makes us even more happy to comply.\n" "\n" ">> +\tregulators {\n" - ">> +\t\tsys_5v0_reg: regulator@1 {\n" + ">> +\t\tsys_5v0_reg: regulator at 1 {\n" ">\n" "> Nit: Why not start the numbering at 0?\n" "\n" @@ -135,7 +127,7 @@ "\n" ">> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi\n" ">\n" - ">> +\tpinmux@70000868 {\n" + ">> +\tpinmux at 70000868 {\n" ">> +\t\tpinctrl-names = \"default\";\n" ">> +\t\tpinctrl-0 = <&state_default>;\n" ">> +\n" @@ -151,4 +143,4 @@ "effort started long before we even learned about the existence of those \n" scripts. Let me look into adding this there as well. -2910ca91763b2f5d2bf78275dd953d21f158f7f41c5ee9120972d1e94e873bd2 +7260ce628077bc49510818638d20217e9c14a4e3acb9d47dc91ba1f52c09d378
diff --git a/a/content_digest b/N2/content_digest index 294e806..d919413 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,18 +1,17 @@ "ref\0c5522b0efcbfc7690dcde6aaf78b9dd568f99604.1401665237.git.marcel@ziswiler.com\0" "ref\0b470c9c8631a6ef021d140192eb07006de3cfd93.1401665237.git.marcel@ziswiler.com\0" "ref\0538CA5C3.5050709@wwwdotorg.org\0" - "ref\0538CA5C3.5050709-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org\0" - "From\0Marcel Ziswiler <marcel-mitwqZ+T+m9Wk0Htik3J/w@public.gmane.org>\0" + "From\0Marcel Ziswiler <marcel@ziswiler.com>\0" "Subject\0Re: [PATCH 3/3] arm: tegra: initial support for apalis t30\0" "Date\0Mon, 02 Jun 2014 22:18:16 +0200\0" - "To\0Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>" - " thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org\0" - "Cc\0linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" - devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " stefan-XLVq0VzYD2Y@public.gmane.org\0" + "To\0Stephen Warren <swarren@wwwdotorg.org>" + " thierry.reding@gmail.com\0" + "Cc\0linux@arm.linux.org.uk" + devicetree@vger.kernel.org + linux-arm-kernel@lists.infradead.org + linux-kernel@vger.kernel.org + linux-tegra@vger.kernel.org + " stefan@agner.ch\0" "\00:1\0" "b\0" "On 06/02/2014 06:26 PM, Stephen Warren wrote:\n" @@ -151,4 +150,4 @@ "effort started long before we even learned about the existence of those \n" scripts. Let me look into adding this there as well. -2910ca91763b2f5d2bf78275dd953d21f158f7f41c5ee9120972d1e94e873bd2 +b4cc72b2ee4b432a9a2c131dffe1285942fb1329df21c50dc503a5d4f169cd5c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.