Re: [PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present

[Paolo Bonzini <pbonzini@redhat.com>]

Il 29/05/2014 05:52, Martin K. Petersen ha scritto:
> +	sdev_printk(KERN_ERR, sdev,
> +		    "%s: VPD page 0x83 NAA descriptor not found\n", __func__);
> +
> +	return;

I suspect this error will be relatively common.

libata for example has

        if (ata_id_has_wwn(args->id)) {
                /* SAT defined lu world wide name */
                /* piv=0, assoc=lu, code_set=binary, designator=NAA */
                rbuf[num + 0] = 1;
                rbuf[num + 1] = 3;
                rbuf[num + 3] = ATA_ID_WWN_LEN;
                num += 4;
                ata_id_string(args->id, (unsigned char *) rbuf + num,
                              ATA_ID_WWN, ATA_ID_WWN_LEN);
                num += ATA_ID_WWN_LEN;
        }
        rbuf[3] = num - 4;    /* page len (assume less than 256 bytes) */

and most of the time IDE disks in a virtual machine are configured without
a WWN.

Paolo