Re: [PATCH] ASoC: rsnd: fixup SSI interrupts style of DeviceTree

[Ben Dooks <ben.dooks@codethink.co.uk>]

On 30/05/14 12:23, Kuninori Morimoto wrote:
> 
> Hi Ben
> 
>>> Hmm...
>>> This driver is still under developing.
>>> And it is very difficult for me to care about out-of-tree Linux.
>>
>> Ok, but we really need to keep in mind that the DT should be kept as
>> stable as possible. We may be out of tree at the moment, but we are
>> trying our best to keep track and feed back our work. This is not
>> helped if we have to do these changes when re-basing.
>>
>> In my view this change does not help the readability, as we now have
>> a large block of interrupts, where before we could easily work out
>> which interrupt was mapped to which SSI.
> 
> OK.
> I thought that 1) current style was not good DT style
> 2) there is a chance to exchange it because upstream
> doesn't have user at this point.
> Can you accept if it can keep compatibility ?

I think the current method is the nicer, it keeps the descriptions
each ssi as close as possible to the ssi. So, in answer to #1 I
think it is the best.

In answer to #2, it would be nicer not to unless you have a good
reason to do this.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius