From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshihiro Shimoda Date: Tue, 03 Jun 2014 02:43:26 +0000 Subject: Re: Ethernet bug at Upstream-v3.15-rcx on Lager. Message-Id: <538D364E.6040605@renesas.com> List-Id: References: <53745E88.7040108@jinso.co.jp> <5374F753.70203@cogentembedded.com> <537564FC.4090905@jinso.co.jp> <5375A877.1090606@renesas.com> <53888FF2.8040505@codethink.co.uk> In-Reply-To: <53888FF2.8040505@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Ben Dooks , cm-hiep@jinso.co.jp Cc: Sergei Shtylyov , netdev@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Simon Horman Hi Ben, (2014/05/30 23:04), Ben Dooks wrote: > On 16/05/14 06:56, Yoshihiro Shimoda wrote: >> Hi Hiep-san, >> >> (2014/05/16 10:08), カオ　ミン　ヒェップ wrote: >>>> >>>>> Please review it when you have time. >>>> >>>> Please try this patch: >>>> >>>> http://marc.info/?l=linux-netdev&m9602519809181 >>>> >>> I have tested this patch on v3.15.0-rc5-00077-g14186fe, and results are the message of >>> "sh-eth r8a7790-ether eth0: Receive FIFO Overflow" has disappeared and sending datagrams is good. >>> (Bandwidth 10M to 100M: Test with 5/5 times by script and by hand are good) >>> >> >> It's nice! >> So, I hope the patch is merged in upstream. >> However, the patch's change log mentioned r8a7790 only. >> The r8a7791's ethernet controller also has this bit. > > The bit update covers both of them as the r8a7790 and r8a7791 both share > the same configuration structure. > > I re-sent the patch but didn't find your email post until after I had > sent it, otherwise I would have mentioned your testing specifically. In > future it would be helpful if you could do the following > > - Mention driver by name in the subject line > - Search the list for previous mentions and reply to that/those threads. > Thank you very much for the comment and your v2 patch! I understood it. Best regards, Yoshihiro Shimoda From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshihiro Shimoda Subject: Re: Ethernet bug at Upstream-v3.15-rcx on Lager. Date: Tue, 3 Jun 2014 11:43:26 +0900 Message-ID: <538D364E.6040605@renesas.com> References: <53745E88.7040108@jinso.co.jp> <5374F753.70203@cogentembedded.com> <537564FC.4090905@jinso.co.jp> <5375A877.1090606@renesas.com> <53888FF2.8040505@codethink.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Sergei Shtylyov , , , Magnus Damm , Simon Horman To: Ben Dooks , Return-path: In-Reply-To: <53888FF2.8040505@codethink.co.uk> Sender: linux-sh-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Ben, (2014/05/30 23:04), Ben Dooks wrote: > On 16/05/14 06:56, Yoshihiro Shimoda wrote: >> Hi Hiep-san, >> >> (2014/05/16 10:08), =E3=82=AB=E3=82=AA=E3=80=80=E3=83=9F=E3=83=B3=E3= =80=80=E3=83=92=E3=82=A7=E3=83=83=E3=83=97 wrote: >>>> >>>>> Please review it when you have time. >>>> >>>> Please try this patch: >>>> >>>> http://marc.info/?l=3Dlinux-netdev&m=3D139602519809181 >>>> >>> I have tested this patch on v3.15.0-rc5-00077-g14186fe, and results= are the message of >>> "sh-eth r8a7790-ether eth0: Receive FIFO Overflow" has disappeared = and sending datagrams is good. >>> (Bandwidth 10M to 100M: Test with 5/5 times by script and by hand a= re good) >>> >> >> It's nice! >> So, I hope the patch is merged in upstream. >> However, the patch's change log mentioned r8a7790 only. >> The r8a7791's ethernet controller also has this bit. >=20 > The bit update covers both of them as the r8a7790 and r8a7791 both sh= are > the same configuration structure. >=20 > I re-sent the patch but didn't find your email post until after I had > sent it, otherwise I would have mentioned your testing specifically. = In > future it would be helpful if you could do the following >=20 > - Mention driver by name in the subject line > - Search the list for previous mentions and reply to that/those threa= ds. >=20 Thank you very much for the comment and your v2 patch! I understood it. Best regards, Yoshihiro Shimoda