From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 4/8] linux-user: arm: handle CPSR.E correctly in strex emulation
Date: Tue, 03 Jun 2014 11:23:28 +0200 [thread overview]
Message-ID: <538D9410.7060300@redhat.com> (raw)
In-Reply-To: <CAFEAcA9GrdAav+4=zXBVOjWGnDTcyY+8ie13hZZY0BRwJ4ubBw@mail.gmail.com>
Il 02/06/2014 18:17, Peter Maydell ha scritto:
> Um. This feels like we're wrongly overloading this flag for
> more than one thing. "Is the user-mode binary BE8?" is
> definitely not a property of the CPU, so it shouldn't be
> a CPU state flag. (Conversely, "is the iside endianness the
> opposite way round to TARGET_WORDS_BIGENDIAN" is a CPU
> property of sorts.) It seems to me that we probably want
> to fix this by more correctly modelling the actual CPU
> state involved here, by having user-mode either set or
> not set SCTLR.B [set only if BE32 binary], and the data
> and insn fetches honour both that and CPSR.E appropriately.)
So basically it's s/bswap_code/!sctlr_b/. Thanks for the suggestion!
Paolo
next prev parent reply other threads:[~2014-06-03 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401392813-29645-1-git-send-email-pbonzini@redhat.com>
[not found] ` <1401392813-29645-5-git-send-email-pbonzini@redhat.com>
[not found] ` <CAFEAcA-yi46ju3i6E+WJWFk-9JW0ydTMjgJHhjA3VCRxvZ13AQ@mail.gmail.com>
[not found] ` <53882A9D.7010501@redhat.com>
2014-06-02 16:17 ` [Qemu-devel] [PATCH v2 4/8] linux-user: arm: handle CPSR.E correctly in strex emulation Peter Maydell
2014-06-03 9:23 ` Paolo Bonzini [this message]
2014-06-03 9:54 ` Peter Maydell
2014-06-03 11:12 ` Paolo Bonzini
2014-06-04 7:48 ` Paolo Bonzini
2014-06-04 8:30 ` Peter Maydell
2014-10-31 20:52 ` [Qemu-devel] [PATCH v2 0/8] target-arm/linux-user-arm: implement setend, CPSR.E, SCTLR.EE Stefan Weil
2015-02-05 17:33 ` Paolo Bonzini
2015-02-05 17:49 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538D9410.7060300@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.