From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/12] sunxi: Add axp152 pmic support
Date: Tue, 03 Jun 2014 19:31:42 +0200 [thread overview]
Message-ID: <538E067E.5010605@redhat.com> (raw)
In-Reply-To: <1401556213.15871.124.camel@hastur.hellion.org.uk>
Hi,
On 05/31/2014 07:10 PM, Ian Campbell wrote:
> On Fri, 2014-05-30 at 11:06 +0200, Hans de Goede wrote:
>> Add support for the x-powers axp152 pmic which is found on most A10s boards.
>
> This driver looks superficially very similar to the last one, have you
> considered merging them?
>
> Other than that most of the generic questions I had on the last one seem
> to appear here too, magic numbers and so on.
The AXP152 and AXP209 look similar, but they have different register
addresses, different ranges for the LDO-s, different number of DCDC
convertors, etc. Doing both in one driver would very quickly become
a very ugly #ifdef fest.
I've applied similar fixes as to the AXP209 driver.
Regards,
Hans
next prev parent reply other threads:[~2014-06-03 17:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 9:06 [U-Boot] sunxi: Bug fixes, sun4i and sun5i support, pmic support and network improvements Hans de Goede
2014-05-30 9:06 ` [U-Boot] [PATCH 01/12] sunxi: mksunxiboot: Fix loading of files with a size which is not a multiple of 4 Hans de Goede
2014-05-30 9:19 ` Ian Campbell
2014-07-23 17:29 ` Siarhei Siamashka
2014-07-23 17:40 ` Ian Campbell
2014-07-23 18:30 ` Ian Campbell
2014-05-30 9:06 ` [U-Boot] [PATCH 02/12] sunxi: Fix u-boot-spl.lds to refer to .vectors Hans de Goede
2014-05-30 9:20 ` Ian Campbell
2014-05-30 9:06 ` [U-Boot] [PATCH 03/12] sunxi: Remove mmc DMA support Hans de Goede
2014-05-30 9:22 ` Ian Campbell
2014-05-30 9:06 ` [U-Boot] [PATCH 04/12] sunxi: Implement reset_cpu Hans de Goede
2014-05-30 9:48 ` Ian Campbell
2014-05-30 13:21 ` Hans de Goede
2014-05-30 9:06 ` [U-Boot] [PATCH 05/12] sunxi: Add sun4i support Hans de Goede
2014-05-31 16:46 ` Ian Campbell
2014-06-01 9:54 ` Hans de Goede
2014-05-30 9:06 ` [U-Boot] [PATCH 06/12] sunxi: Add sun5i support Hans de Goede
2014-05-31 16:51 ` Ian Campbell
2014-05-30 9:06 ` [U-Boot] [PATCH 07/12] sunxi: Add i2c support Hans de Goede
2014-05-31 16:53 ` Ian Campbell
2014-05-30 9:06 ` [U-Boot] [PATCH 08/12] sunxi: Add axp209 pmic support Hans de Goede
2014-05-31 17:08 ` Ian Campbell
2014-06-03 17:12 ` Hans de Goede
2014-05-30 9:06 ` [U-Boot] [PATCH 09/12] sunxi: Add axp152 " Hans de Goede
2014-05-31 17:10 ` Ian Campbell
2014-06-03 17:31 ` Hans de Goede [this message]
2014-05-30 9:06 ` [U-Boot] [PATCH 10/12] net: Rename and cleanup sunxi (Allwinner) emac driver Hans de Goede
2014-05-31 17:19 ` Ian Campbell
2014-05-30 9:06 ` [U-Boot] [PATCH 11/12] sunxi: enable emac for sun4i Hans de Goede
2014-05-31 17:20 ` Ian Campbell
2014-05-30 9:06 ` [U-Boot] [PATCH 12/12] sunxi: Add support for using MII phy-s with the GMAC nic Hans de Goede
2014-05-30 10:26 ` Ian Campbell
2014-05-30 13:18 ` Hans de Goede
2014-05-31 9:51 ` Ian Campbell
2014-05-31 9:59 ` Ian Campbell
2014-05-31 11:45 ` Hans de Goede
2014-05-31 12:13 ` Ian Campbell
2014-05-31 14:08 ` Hans de Goede
2014-05-31 14:25 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538E067E.5010605@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.