Re: [Qemu-devel] [PATCH v3 1/2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

On 06/03/2014 03:58 PM, Michael Roth wrote:

>> Bikeshedding on the proposed name: given that 'fs' is an abbreviation of
>> 'filesystem', "fsfreeze-freeze-filesystems" sounds rather redundant.  I
>> would suggest guest-fsfreeze-list as a shorter name that conveys the
>> intent, without quite as much repetition.
> 
> Somewhat agree, though I think we should retain the guest-<command_group>-<verb>
> structure and at least go with guest-fsfreeze-freeze-list.

guest- prefix is uncontroversial
command_group is 'fsfreeze'.
Currently in that group are the verbs 'status', 'freeze', and 'thaw';
and my proposal is to add 'list' (not 'freeze-list') as the new verb
(just as we don't have 'freeze-status' as a verb).

Oh, and adding this command to freeze by list may require a change to
the existing guest-fsfreeze-status command to report a third enum value
of 'partial' (neither fully 'thawed' nor fully 'frozen').

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]