From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws08U-0001NG-Af for qemu-devel@nongnu.org; Tue, 03 Jun 2014 21:37:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ws08H-0007gi-1w for qemu-devel@nongnu.org; Tue, 03 Jun 2014 21:37:01 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:34360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws08G-0007gT-T0 for qemu-devel@nongnu.org; Tue, 03 Jun 2014 21:36:48 -0400 Received: by mail-pd0-f179.google.com with SMTP id fp1so5381128pdb.38 for ; Tue, 03 Jun 2014 18:36:48 -0700 (PDT) Message-ID: <538E782B.6080106@ozlabs.ru> Date: Wed, 04 Jun 2014 11:36:43 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1401787684-31895-1-git-send-email-aik@ozlabs.ru> <1401787684-31895-6-git-send-email-aik@ozlabs.ru> <538DF948.2080903@gmail.com> In-Reply-To: <538DF948.2080903@gmail.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 05/29] target-ppc: Add "POWER" prefix to MMCRA PMU registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Alexander Graf On 06/04/2014 02:35 AM, Tom Musta wrote: > On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote: >> Since we started adding "POWER" prefix to 64bit PMU SPRs, let's finish >> the transition and fix MMCRA and define a hypv version of it. >> >> Signed-off-by: Alexey Kardashevskiy > > I'm still not a fan of "SPR_POWER_*" since these are now in the ISA (the "_POWER_" seems redundant). And I am still a fan of having specific name in a macro if there is chance that SPR with the same name can have different numbers on different platforms :) Alex, judge please :) > Aside from that ... > > Reviewed-by: Tom Musta Yup, thanks, putting it into my git tree to have them all in v5! -- Alexey