Re: [PATCH 6/6 RFC v2] btrfs: revamp /sys/fs/btrfs/<fsid>/devices

[Anand Jain <Anand.Jain@oracle.com>]

David,

  Thanks for the comments


>> As of now with out this patch the sysfs interface under dir
>> /sys/fs/btrfs/<fsid>/devices is just link to the block devs.
>
> At this point it's part of the sysfs ABI and should not be changed.

  can't we lean on the experimental clause to change it either ?
  practically is there anything thats already depending on this
  dev link ?

> Example:
>
> /sys/fs/btrfs/devmap/by-id/
>    contains directories with integer numbers that represent devices

  This won't work.
  devid isn't unique at the btrfs-module level. its under fsid.


  [IMO. its ok if the ideas doesn't match ;-) as in any case I
  will be doing it in the way the most want]


  When user come to sys/fs/btrfs their  "main"  reference of identifying
  a  "volume"  is the FSID/label.  not individual disks.
  Of course disks are the sub-references of a volume.


  I suggest - first do the way btrfs-kernel does (which is - group disks
  under fsid) And later create abstraction links as needed which we don't
  have to worry about as of now.


Thanks, Anand