From: Jan Kiszka <jan.kiszka@siemens.com>
To: Bandan Das <bsd@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] Emulate VMXON region correctly
Date: Wed, 04 Jun 2014 09:18:36 +0200 [thread overview]
Message-ID: <538EC84C.90401@siemens.com> (raw)
In-Reply-To: <jpgoay9eotd.fsf@nelium.bos.redhat.com>
On 2014-06-03 22:11, Bandan Das wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> Il 06/05/2014 08:19, Bandan Das ha scritto:
>>> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=54521
>>>
>>> The vmxon region is unused by nvmx, but adding these checks
>>> are probably harmless and may detect buggy L1 hypervisors in
>>> the future!
>>
>> Applied to kvm/queue, unit test patches are welcome (hint, hint!).
>
> Jan and Paolo,
>
> Ok, I thought a little bit about this and I am wondering what
> kind of tests we could have here. All the changes are pure
> checks and no data is returned back to the guest. The
> vmxon code in kvm-unit-tests already does the right thing i.e
> sets the revision identifier, allocs a page for the region etc
Then try to do the wrong thing in the unit test and validate that you
get the right error report from the emulated VMX hardware.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2014-06-04 7:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 6:19 [PATCH v2 0/4] Emulate VMXON region correctly Bandan Das
2014-05-06 6:19 ` [PATCH v2 1/4] KVM: nVMX: rearrange get_vmx_mem_address Bandan Das
2014-05-06 6:19 ` [PATCH v2 2/4] KVM: nVMX: additional checks on vmxon region Bandan Das
2014-05-06 6:19 ` [PATCH v2 3/4] KVM: nVMX: fail on invalid vmclear/vmptrld pointer Bandan Das
2014-05-06 6:19 ` [PATCH v2 4/4] KVM: nVMX: move vmclear and vmptrld pre-checks to nested_vmx_check_vmptr Bandan Das
2014-05-06 17:01 ` [PATCH v2 0/4] Emulate VMXON region correctly Paolo Bonzini
2014-06-03 20:11 ` Bandan Das
2014-06-04 7:18 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538EC84C.90401@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=bsd@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.