All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: quintela@redhat.com, QEMU Trivial <qemu-trivial@nongnu.org>,
	Michael Tokarev <mjt@tls.msk.ru>,
	dgilbert@redhat.com, QEMU Developers <qemu-devel@nongnu.org>,
	owasserm@redhat.com, arei.gonglei@huawei.com,
	Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH-trivial] arch_init.c: Always be sure that 'encoded_buf' and 'current_buf' are lock protected
Date: Wed, 04 Jun 2014 18:32:04 +0800	[thread overview]
Message-ID: <538EF5A4.1030500@gmail.com> (raw)
In-Reply-To: <871tv52ihw.fsf@blackfin.pond.sub.org>



On 06/04/2014 04:20 PM, Markus Armbruster wrote:
> Chen Gang <gang.chen.5i5j@gmail.com> writes:
> 
>> 'encoded_buf' and 'current_buf' are lock protected during using in
>> save_xbzrle_page() in ram_save_page(), and during freeing in
>> migration_end().
>>
>> So recommend to let them lock protected during starting, just like we
>> have done to 'cache'.
> 
> I'd recommend against routing locking patches through -trivial.  The
> code has maintainers, and you cc'ed them.
> 

OK, I shall remove -trivial for locking patches, next time.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed


WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: quintela@redhat.com, QEMU Trivial <qemu-trivial@nongnu.org>,
	Michael Tokarev <mjt@tls.msk.ru>,
	dgilbert@redhat.com, QEMU Developers <qemu-devel@nongnu.org>,
	owasserm@redhat.com, arei.gonglei@huawei.com
Subject: Re: [Qemu-devel] [PATCH-trivial] arch_init.c: Always be sure that 'encoded_buf' and 'current_buf' are lock protected
Date: Wed, 04 Jun 2014 18:32:04 +0800	[thread overview]
Message-ID: <538EF5A4.1030500@gmail.com> (raw)
In-Reply-To: <871tv52ihw.fsf@blackfin.pond.sub.org>



On 06/04/2014 04:20 PM, Markus Armbruster wrote:
> Chen Gang <gang.chen.5i5j@gmail.com> writes:
> 
>> 'encoded_buf' and 'current_buf' are lock protected during using in
>> save_xbzrle_page() in ram_save_page(), and during freeing in
>> migration_end().
>>
>> So recommend to let them lock protected during starting, just like we
>> have done to 'cache'.
> 
> I'd recommend against routing locking patches through -trivial.  The
> code has maintainers, and you cc'ed them.
> 

OK, I shall remove -trivial for locking patches, next time.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

  reply	other threads:[~2014-06-04 10:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02 12:35 [Qemu-trivial] [PATCH-trivial] arch_init.c: Always be sure that 'encoded_buf' and 'current_buf' are lock protected Chen Gang
2014-06-02 12:35 ` [Qemu-devel] " Chen Gang
2014-06-03  7:31 ` [Qemu-trivial] " ChenLiang
2014-06-03  7:31   ` ChenLiang
2014-06-03 13:45   ` [Qemu-trivial] " Chen Gang
2014-06-03 13:45     ` Chen Gang
2014-06-04 10:01     ` [Qemu-trivial] " Dr. David Alan Gilbert
2014-06-04 10:01       ` Dr. David Alan Gilbert
2014-06-04 10:49       ` [Qemu-trivial] " Chen Gang
2014-06-04 10:49         ` Chen Gang
2014-06-04  8:20 ` [Qemu-trivial] " Markus Armbruster
2014-06-04  8:20   ` Markus Armbruster
2014-06-04 10:32   ` Chen Gang [this message]
2014-06-04 10:32     ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538EF5A4.1030500@gmail.com \
    --to=gang.chen.5i5j@gmail.com \
    --cc=arei.gonglei@huawei.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=owasserm@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.