All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] v4l: subdev: Unify argument validation across IOCTLs
Date: Wed, 04 Jun 2014 14:17:56 +0300	[thread overview]
Message-ID: <538F0064.7000107@linux.intel.com> (raw)
In-Reply-To: <1693642.21y0Pscz7q@avalon>

Hi Laurent,

Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.

Thanks for the review!

> On Tuesday 03 June 2014 12:25:16 Sakari Ailus wrote:
...
>> @@ -202,26 +251,20 @@ static long subdev_do_ioctl(struct file *file,
>> unsigned int cmd, void *arg) #if defined(CONFIG_VIDEO_V4L2_SUBDEV_API)
>>   	case VIDIOC_SUBDEV_G_FMT: {
>>   		struct v4l2_subdev_format *format = arg;
>> +		int rval = check_format(sd, format);
>
> How about declaring the variable once only at the beginning of the function ?

I'll change that and resend.

-- 
Sakari Ailus
sakari.ailus@linux.intel.com

      reply	other threads:[~2014-06-04 11:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03  9:25 [PATCH 1/1] v4l: subdev: Unify argument validation across IOCTLs Sakari Ailus
2014-06-03 17:16 ` Laurent Pinchart
2014-06-04 11:17   ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538F0064.7000107@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.