From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/hvm: Correct
 hvm_ioreq_server_alloc_rangesets() failure path
Date: Wed, 4 Jun 2014 13:25:17 +0100
Message-ID: <538F102D.2080304@citrix.com>
References: <1401879643-3555-1-git-send-email-andrew.cooper3@citrix.com>
	<538F2BA20200007800017BF3@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <538F2BA20200007800017BF3@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Paul Durrant <paul.durrant@citrix.com>, Keir Fraser <keir@xen.org>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 04/06/14 13:22, Jan Beulich wrote:
>
>> @@ -861,24 +873,11 @@ static int hvm_ioreq_server_alloc_rangesets(struct hvm_ioreq_server *s,
>>      return 0;
>>  
>>   fail:
>> -    while ( --i >= 0 )
> ... the one line equivalent fix would have been to use while ( i-- ).
>
> Jan

I was considering the possible case where alloc/free_rangesets() gain
further moving parts, although I guess is probably unlikely.

~Andrew