Re: [Qemu-devel] [PATCH 3/3] QMP: Add support for Archipelago

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2453 bytes --]

On 06/04/2014 05:30 AM, Chrysostomos Nanakos wrote:
> Introduce new enum BlockdevOptionsArchipelago.
> 
> @volume:              #Name of the Archipelago volume image
> 
> @mport:               #'mport' is the port number on which mapperd is
>                       listening. This is optional and if not specified,
>                       QEMU will make Archipelago to use the default port.
> 
> @vport:               #'vport' is the port number on which vlmcd is
>                       listening. This is optional and if not specified,
>                       QEMU will make Archipelago to use the default port.
> 
> Signed-off-by: Chrysostomos Nanakos <cnanakos@grnet.gr>
> ---
>  qapi-schema.json |   31 +++++++++++++++++++++++++++++--
>  1 file changed, 29 insertions(+), 2 deletions(-)
> 

> +
> +##
> +# @BlockdevOptionsArchipelago
> +#
> +# Driver specific block device options for Archipelago.
> +#
> +# @volume:              #Name of the Archipelago volume image
> +#

s/#Name/Name/ (we only use # for the initial comment, and for the
special marking '#optional' that designates when a parameter is optional)

> +#
> +# @mport:               #'mport' is the port number on which mapperd is
> +#                       listening. This is optional
> +#                       and if not specified, QEMU will make Archipelago to
> +#                       use the default port.

@mport: #optional The port number ...

s/to use/use/


> +#
> +# @vport:               #'vport' is the port number on which vlmcd is
> +#                       listening. This is optional
> +#                       and if not specified, QEMU will make Archipelago to
> +#                       use the default port.

@vport: #optional The port number...

s/to use/use/

> +# Since: 2.0

2.1

> +##
> +{ 'type': 'BlockdevOptionsArchipelago',
> +  'data': { 'volume': 'str',
> +            '*mport': 'int',
> +            '*vport': 'int' } }
> +
>  ##
>  # @BlkdebugEvent
>  #
> @@ -4616,6 +4642,7 @@
>        'vhdx':       'BlockdevOptionsGenericFormat',
>        'vmdk':       'BlockdevOptionsGenericCOWFormat',
>        'vpc':        'BlockdevOptionsGenericFormat',
> +      'archipelago': 'BlockdevOptionsArchipelago',
>        'quorum':     'BlockdevOptionsQuorum'
>    } }
>  
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]