Re: [PATCH net-next v10 1/7] xen-netback: Move grant_copy_op array back into struct xenvif.

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 06/04/2014 06:52 PM, David Vrabel wrote:

>>> This array was allocated separately in commit ac3d5ac2 ("xen-netback:
>>> fix guest-receive-side array sizes") due to it being very large, and a
>>> struct xenvif is allocated as the netdev_priv part of a struct
>>> net_device, i.e. via kmalloc() but falling back to vmalloc() if the
>>> initial alloc. fails.

>>> In preparation for the multi-queue patches, where this array becomes
>>> part of struct xenvif_queue and is always allocated through vzalloc(),
>>> move this back into the struct xenvif.

>>     Won't this cause an allocation failure and so break bisection at this
>> patch?

> No. As Andrew already said: "...falling back to vmalloc() if the
> initial alloc. fails."

    Ah, sorry, I've managed to forget about that part. :-/

> David

WBR, Sergei