From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shaohua Li <shli@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch]blk-mq: blk_mq_tag_to_rq should handle flush request
Date: Wed, 04 Jun 2014 09:19:55 -0600 [thread overview]
Message-ID: <538F391B.8070005@kernel.dk> (raw)
In-Reply-To: <20140604151643.GA6344@infradead.org>
On 2014-06-04 09:16, Christoph Hellwig wrote:
> On Wed, Jun 04, 2014 at 09:11:47AM -0600, Jens Axboe wrote:
>> On 2014-06-04 09:10, Christoph Hellwig wrote:
>>> On Wed, Jun 04, 2014 at 09:08:12AM -0600, Jens Axboe wrote:
>>>>> The performance regression is caused by "blk-mq: avoid code
>>>>> duplication", but I don't really understand why yet.
>>>>
>>>> Gah, looks like this one dropped the tag idling. I bet that is why.
>>>
>>> Ah, thanks. It's indeed exactly the same sort of slow down I bisected
>>> back then, this should have rung a bell instead of keeping me occupied
>>> for hours..
>>
>> Patch is committed :-)
>
> Oh well, I had just prepared the same one for you, but I want to at
> least do basic sanity checking of my rebased tree with the fixes applied
> now that I'm done bisecting.
Please do. If there's anything else I need, let me know. It wasn't clear
to me if the cdb patch was in blk-mq or scsi-mq. I'll flush my queue out
this afternoon, so that -rc1 will hopefully have everything in a sane state.
--
Jens Axboe
next prev parent reply other threads:[~2014-06-04 15:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 12:07 [patch]blk-mq: blk_mq_tag_to_rq should handle flush request Shaohua Li
2014-05-09 15:00 ` Christoph Hellwig
2014-05-10 4:00 ` Shaohua Li
2014-05-11 17:40 ` Jens Axboe
2014-05-30 14:09 ` Jens Axboe
2014-06-04 11:11 ` Christoph Hellwig
2014-06-04 14:15 ` Jens Axboe
2014-06-04 14:20 ` Christoph Hellwig
2014-06-04 14:54 ` Jens Axboe
2014-06-04 14:58 ` Christoph Hellwig
2014-06-04 15:02 ` Jens Axboe
2014-06-04 15:05 ` Christoph Hellwig
2014-06-04 15:08 ` Jens Axboe
2014-06-04 15:10 ` Christoph Hellwig
2014-06-04 15:11 ` Jens Axboe
2014-06-04 15:16 ` Christoph Hellwig
2014-06-04 15:19 ` Jens Axboe [this message]
2014-06-04 15:22 ` Christoph Hellwig
2014-06-04 15:28 ` Jens Axboe
2014-06-04 15:31 ` Christoph Hellwig
2014-06-04 15:39 ` Jens Axboe
2014-06-04 15:47 ` Jens Axboe
2014-06-04 16:25 ` Jens Axboe
2014-06-05 1:27 ` Shaohua Li
2014-06-05 2:05 ` Jens Axboe
2014-06-05 2:27 ` Shaohua Li
2014-06-05 2:40 ` Jens Axboe
2014-06-04 15:43 ` Ming Lei
2014-06-04 15:48 ` Jens Axboe
2014-06-04 16:00 ` Ming Lei
2014-06-04 16:09 ` Jens Axboe
2014-06-04 16:26 ` Ming Lei
2014-06-04 16:28 ` Jens Axboe
2014-06-04 16:33 ` Christoph Hellwig
2014-06-04 16:36 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F391B.8070005@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.