From: Alex Elder <elder@ieee.org>
To: Ilya Dryomov <ilya.dryomov@inktank.com>, ceph-devel@vger.kernel.org
Subject: Re: [PATCH] rbd: fix ida/idr memory leak
Date: Wed, 04 Jun 2014 12:01:56 -0500 [thread overview]
Message-ID: <538F5104.4000705@ieee.org> (raw)
In-Reply-To: <1401899917-11254-1-git-send-email-ilya.dryomov@inktank.com>
On 06/04/2014 11:38 AM, Ilya Dryomov wrote:
> ida_destroy() needs to be called on module exit to release ida caches.
Looks good to me.
Reviewed-by: Alex Elder <elder@linaro.org>
> Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
> ---
> drivers/block/rbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 94747afc2e78..ecdd4aee173c 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -5464,6 +5464,7 @@ err_out_slab:
>
> static void __exit rbd_exit(void)
> {
> + ida_destroy(&rbd_dev_id_ida);
> rbd_sysfs_cleanup();
> if (single_major)
> unregister_blkdev(rbd_major, RBD_DRV_NAME);
>
prev parent reply other threads:[~2014-06-04 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 16:38 [PATCH] rbd: fix ida/idr memory leak Ilya Dryomov
2014-06-04 17:01 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F5104.4000705@ieee.org \
--to=elder@ieee.org \
--cc=ceph-devel@vger.kernel.org \
--cc=ilya.dryomov@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.