From: "Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/4] getdate.3: Use blank definition of _GNU_SOURCE
Date: Wed, 04 Jun 2014 20:44:32 +0200 [thread overview]
Message-ID: <538F6910.9010704@gmail.com> (raw)
In-Reply-To: <1401899608-30515-2-git-send-email-rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
Thanks, Rasmus. Applied.
Cheers,
Michael
On 06/04/2014 06:33 PM, Rasmus Villemoes wrote:
> Only the definedness of _GNU_SOURCE matters, so eliminate a possible
> source of confusion by not using a specific replacement text in the
> example program.
>
> Signed-off-by: Rasmus Villemoes <rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
> ---
>
> Notes:
> Or maybe the intention was to define _XOPEN_SOURCE to the value 500,
> since that is the minimal requirement for getdate(), and getdate_r()
> is not used in the example.
>
> man3/getdate.3 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/getdate.3 b/man3/getdate.3
> index f286f98..df882b9 100644
> --- a/man3/getdate.3
> +++ b/man3/getdate.3
> @@ -272,7 +272,7 @@ Call 3 ("12:22:33") succeeded:
> .SS Program source
> \&
> .nf
> -#define _GNU_SOURCE 500
> +#define _GNU_SOURCE
> #include <time.h>
> #include <stdio.h>
> #include <stdlib.h>
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-06-04 18:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 16:33 [PATCH 0/4] Trivialities Rasmus Villemoes
[not found] ` <1401899608-30515-1-git-send-email-rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
2014-06-04 16:33 ` [PATCH 1/4] getdate.3: Use blank definition of _GNU_SOURCE Rasmus Villemoes
[not found] ` <1401899608-30515-2-git-send-email-rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
2014-06-04 18:44 ` Michael Kerrisk (man-pages) [this message]
2014-06-04 16:33 ` [PATCH 2/4] open_by_handle_at.2: Add reference to feature_test_macros(7) Rasmus Villemoes
[not found] ` <1401899608-30515-3-git-send-email-rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
2014-06-04 18:45 ` Michael Kerrisk (man-pages)
2014-06-04 16:33 ` [PATCH 3/4] recvmmsg.2: " Rasmus Villemoes
[not found] ` <1401899608-30515-4-git-send-email-rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
2014-06-04 18:45 ` Michael Kerrisk (man-pages)
2014-06-04 16:33 ` [PATCH 4/4] sendmmsg.2: " Rasmus Villemoes
[not found] ` <1401899608-30515-5-git-send-email-rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>
2014-06-04 18:45 ` Michael Kerrisk (man-pages)
2014-06-04 18:54 ` [PATCH 0/4] Trivialities Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F6910.9010704@gmail.com \
--to=mtk.manpages-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rv-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.