From: Richard Henderson <rth@twiddle.net>
To: Alexander Graf <agraf@suse.de>, qemu-ppc@nongnu.org
Cc: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] PPC: e500: Merge 32 and 64 bit SPE emulation
Date: Wed, 04 Jun 2014 14:57:12 -0700 [thread overview]
Message-ID: <538F9638.8000404@twiddle.net> (raw)
In-Reply-To: <538F94D9.1000203@suse.de>
On 06/04/2014 02:51 PM, Alexander Graf wrote:
>
> On 04.06.14 23:38, Richard Henderson wrote:
>> On 06/04/2014 02:09 PM, Alexander Graf wrote:
>>> @@ -9030,13 +8820,10 @@ static inline void gen_evmwumi(DisasContext *ctx)
>>> t1 = tcg_temp_new_i64();
>>> /* t0 := rA; t1 := rB */
>>> -#if defined(TARGET_PPC64)
>>> - tcg_gen_ext32u_tl(t0, cpu_gpr[rA(ctx->opcode)]);
>>> - tcg_gen_ext32u_tl(t1, cpu_gpr[rB(ctx->opcode)]);
>>> -#else
>>> tcg_gen_extu_tl_i64(t0, cpu_gpr[rA(ctx->opcode)]);
>>> + tcg_gen_ext32u_i64(t0, t0);
>> Better in one step:
>>
>> tcg_gen_ext32u_i64(t0, cpu_gpr[rA(ctx->opcode)]);
>
> But cpu_gpr can be i32 for qemu-system-ppc, no?
Err.. right. We don't have an extend define for this mix.
r~
next prev parent reply other threads:[~2014-06-04 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 21:09 [Qemu-devel] [PATCH 1/2] TCG: Fix tcg_gen_extr_i64_tl for 32bit Alexander Graf
2014-06-04 21:09 ` [Qemu-devel] [PATCH 2/2] PPC: e500: Merge 32 and 64 bit SPE emulation Alexander Graf
2014-06-04 21:38 ` Richard Henderson
2014-06-04 21:51 ` Alexander Graf
2014-06-04 21:57 ` Richard Henderson [this message]
2014-06-04 21:12 ` [Qemu-devel] [PATCH 1/2] TCG: Fix tcg_gen_extr_i64_tl for 32bit Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F9638.8000404@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=tommusta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.