From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v3 3/7] r8a7790.dtsi: add vin[0-3] nodes
Date: Wed, 04 Jun 2014 22:45:30 +0000 [thread overview]
Message-ID: <538FA18A.4040505@cogentembedded.com> (raw)
Hello.
On 04/14/2014 02:36 PM, Ben Dooks wrote:
> Add nodes for the four video input channels on the R8A7790.
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
It looks like I've overlooked something while reviewing this patch back in
April...
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index a1e7c39..de0e53e 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
[...]
> @@ -395,6 +399,38 @@
> status = "disabled";
> };
>
> + vin0: vin@0xe6ef0000 {
Drop "0x" form the unit-address please. Also, name should probably be
"video", more in line with the ePAPR standard...
WBR, Sergei
next reply other threads:[~2014-06-04 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 22:45 Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-14 10:36 [PATCH v3 3/7] r8a7790.dtsi: add vin[0-3] nodes Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538FA18A.4040505@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.