Re: [PATCH 00/18] spi: rspi: Add DMA support for QSPI on R-Car Gen2

[Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>]

Hi Geert-san,

Thank you for the patches!

(2014/06/02 22:38), Geert Uytterhoeven wrote:
> This patch series refactors the Renesas SPI driver and adds DMA support
> using the SPI DMA framework for QSPI on R-Car Gen2, for Single, Dual, and
> Quad SPI Transfers.
> It also adds DMA support for RZ/A1H, but this was untested.
> 
> Apart from refactorings that don't change behavior:
>   - [02/18] reverts a (harmless?) behavioral change for RSPI on SH,
>   - [03/18] removes 16-bit DMA support, which has no in-tree users.
> 	    16-bit DMA support requires using a double-sized buffer to
> 	    accomodate the interleaved data format.
> 	    If there's a strong requirement to keep this, I think it's best
> 	    to re-add support after this series.

I agree with you.
(I wrote this 16-bit DMA function. But, as you know, nobody uses this function.)

< snip >
>  Documentation/devicetree/bindings/spi/spi-rspi.txt |   6 +
>  drivers/spi/spi-rspi.c                             | 604 ++++++++-------------
>  include/linux/spi/rspi.h                           |   2 -
>  3 files changed, 228 insertions(+), 384 deletions(-)

All of the patch series:
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda