All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: ronnie sahlberg <ronniesahlberg@gmail.com>, Peter Lieven <pl@kamp.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/iscsi: use 16 byte CDBs only when necessary
Date: Thu, 05 Jun 2014 13:12:09 +0400	[thread overview]
Message-ID: <53903469.8070902@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAN05THTaDzwHf-A0SmAGgmODhoqsGoyyn7apiBmnwYeFBQc63Q@mail.gmail.com>

04.06.2014 18:00, ronnie sahlberg wrote:
> That would mean you get to use the 10 version of the cdb even for very
> large devices (as long as the IO is for blocks at the beginning of the
> device) and thus provide partial avoidance of this issue for those
> large devices.

That may make some bugs "ghosty", so to say.  Ie, if there's a bug in/with
16 version of a command, you'll hit it only when you actually try to access
a "far" area of a drive.  Which means you're unlikely to hit it while trying
to reproduce in a clean environment, even after using a large device.  Or,
the bug will be triggered at random, since data placement on the filesystem
is effectively (from user PoV) random.

To my taste it is better to make it a bit more deterministic.

Thanks,

/mjt

  parent reply	other threads:[~2014-06-05  9:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 13:47 [Qemu-devel] [PATCH] block/iscsi: use 16 byte CDBs only when necessary Peter Lieven
2014-06-04 14:00 ` ronnie sahlberg
2014-06-04 14:43   ` Peter Lieven
2014-06-04 14:54     ` ronnie sahlberg
2014-06-05  9:12   ` Michael Tokarev [this message]
2014-06-05  9:27     ` Peter Lieven
2014-06-17  6:14     ` Peter Lieven
2014-06-17 11:15       ` Paolo Bonzini
2014-06-17 11:37         ` Peter Lieven
2014-06-17 11:46           ` Paolo Bonzini
2014-06-17 11:50             ` Peter Lieven
2014-06-17 13:45             ` Peter Lieven
2014-09-01 15:21             ` Peter Lieven
2014-09-02 15:28               ` ronnie sahlberg
2014-09-02 18:14                 ` Peter Lieven
2014-09-02 19:30                 ` Peter Lieven
2014-09-03  8:09                   ` Peter Lieven
2014-09-03 12:31                     ` Stefan Hajnoczi
2014-09-03 13:13                       ` Peter Lieven
2014-09-03 14:17                     ` ronnie sahlberg
2014-09-03 14:18                       ` Paolo Bonzini
2014-09-03 14:48                         ` ronnie sahlberg
2014-09-03 19:29                           ` Peter Lieven
2014-06-04 15:31 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53903469.8070902@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.