All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Paul Janzen <pcj@pauljanzen.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scsi-disk.c: Fix compilation with -DDEBUG_SCSI
Date: Thu, 05 Jun 2014 12:33:50 +0200	[thread overview]
Message-ID: <5390478E.20805@redhat.com> (raw)
In-Reply-To: <86r433vr9a.fsf@lautaret.pauljanzen.org>

Il 05/06/2014 07:33, Paul Janzen ha scritto:
> In scsi-disk.c, if you #define DEBUG_SCSI=1, you get:
> hw/scsi/scsi-disk.c: In function 'scsi_disk_emulate_command':
> hw/scsi/scsi-disk.c:2018: error: 'SCSIRequest' has no member named 'buf'
>
> Change the debugging statement to match the actual value tested.
>
> Signed-off-by: Paul Janzen <pcj@pauljanzen.org>
> ---
>  hw/scsi/scsi-disk.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index 48a28ae..5ff4ae4 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -2015,7 +2015,7 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf)
>      case VERIFY_10:
>      case VERIFY_12:
>      case VERIFY_16:
> -        DPRINTF("Verify (bytchk %lu)\n", (r->req.buf[1] >> 1) & 3);
> +        DPRINTF("Verify (bytchk %d)\n", (req->cmd.buf[1] >> 1) & 3);
>          if (req->cmd.buf[1] & 6) {
>              goto illegal_request;
>          }
>

Thanks, applied to scsi-next.

Paolo

      reply	other threads:[~2014-06-05 10:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05  5:33 [Qemu-devel] [PATCH] scsi-disk.c: Fix compilation with -DDEBUG_SCSI Paul Janzen
2014-06-05 10:33 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5390478E.20805@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=pcj@pauljanzen.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.