From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsXHR-0007GM-1J for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:00:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsXHI-0003DA-IL for qemu-devel@nongnu.org; Thu, 05 Jun 2014 09:00:28 -0400 Message-ID: <539069E1.8040309@suse.de> Date: Thu, 05 Jun 2014 15:00:17 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1401951221-32613-1-git-send-email-gwshan@linux.vnet.ibm.com> <1401951221-32613-5-git-send-email-gwshan@linux.vnet.ibm.com> In-Reply-To: <1401951221-32613-5-git-send-email-gwshan@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 4/4] sPAPR: Implement sPAPRPHBClass::eeh_handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gavin Shan , qemu-ppc@nongnu.org Cc: aik@ozlabs.ru, alex.williamson@redhat.com, qiudayu@linux.vnet.ibm.com, qemu-devel@nongnu.org On 05.06.14 08:53, Gavin Shan wrote: > The patch implements sPAPRPHBClass::eeh_handler so that the > EEH RTAS requests can be routed to VFIO for further handling. > > Signed-off-by: Gavin Shan Just to make sure I grasp this correctly. We have PHBs that are VFIO PHBs and PHBs that are emulation PHBs. Emulation PHBs can only have emulated devices attached. VFIO PHBs can only have a single IOMMU group's devices attached each. A container can not span 2 different VFIO PHBs. Is this correct? If not the code below needs to take care of any abstraction we have in between and maybe limit scope a bit to make sure the guest doesn't kill devices on other PHBs :). Alex