Re: [PATCH V2 net-next 0/5] amd-xgbe: AMD 10Gb Ethernet driver

[Tom Lendacky <thomas.lendacky@amd.com>]

On 06/04/2014 04:39 PM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 04 Jun 2014 14:36:05 -0700 (PDT)
>
>> From: Tom Lendacky <thomas.lendacky@amd.com>
>> Date: Wed, 4 Jun 2014 11:11:31 -0500
>>
>>> The following series implements support for the new AMD 10Gb Ethernet
>>> driver (amd-xgbe).  It includes the 10Gb Ethernet driver as well as
>>> a 10Gb Ethernet PHY driver.
>>>
>>> This patch series is based on net-next.
>>>
>>> Changes in V2:
>>>    - Add phy-mode to the amd-xgbe device bindings
>>>    - Obtain the phy-mode from the device tree
>>>    - Reference ethernet.txt device bindings for phy-handle and phy-mode
>>>    - Connect/disconnect to/from phy during probe/remove, instead of open/close
>>>    - Fixes for jumbo packet support / MTU changes
>>>    - Formatting changes for debug packet dump
>>>    - Free resources in the phylib driver remove function
>>>    - Proper NP NULL message during auto-negotiation
>>
>> Series applied, thanks.
>
> I had to revert, this breaks the build:
>
> drivers/net/phy/amd-xgbe-phy.c: In function ‘amd_xgbe_phy_probe’:
> drivers/net/phy/amd-xgbe-phy.c:1251:2: error: implicit declaration of function ‘of_dev_put’ [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/net/phy/amd-xgbe-phy.o] Error 1
> make[2]: *** [drivers/net/phy] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers/net] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [drivers] Error 2
>

Sorry about that, I'll fix the config dependencies and send out a
V3.

Tom