From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH 1/2] ALSA: soundcore: coding style fixes Date: Thu, 05 Jun 2014 15:59:03 +0200 Message-ID: <539077A7.1080007@zonque.org> References: <1401970346-9043-1-git-send-email-zonque@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.zonque.de (svenfoo.org [82.94.215.22]) by alsa0.perex.cz (Postfix) with ESMTP id A828726568C for ; Thu, 5 Jun 2014 15:59:15 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 06/05/2014 03:53 PM, Takashi Iwai wrote: > At Thu, 5 Jun 2014 14:12:25 +0200, > Daniel Mack wrote: >> >> sound/sounc_core.c has a larger number of style issues. Fix them to make the >> code more readable. No functional change. >> >> Signed-off-by: Daniel Mack > > Thanks for the patches, but are you going to fix anything in these > codes along with them? Such coding style fixes just stir git history, > which make often annoying for backporting or reviewing. So, basically > I'd take such cleanup patches only if the real fixes will come > together. Yeah, I know that code is legacy. I was just skimming over the sources to trace a bug report on alsa-user, and stumbled over so many style issues that made reading the code harder than necessary that I couldn't resist fixing them :) Hence, I don't know yet. Maybe there will be a fix as well at some late point. Feel free to ignore the patches for now. I'll stash and resend them along with real fixes in case there are any. Thanks, Daniel