From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH v2 11/17] hotplug: add FreeBSD vif-bridge Date: Thu, 5 Jun 2014 17:32:35 +0200 Message-ID: <53908D93.6030201@citrix.com> References: <1401721703-34974-1-git-send-email-roger.pau@citrix.com> <1401721703-34974-12-git-send-email-roger.pau@citrix.com> <1401981984.15729.140.camel@hastur.hellion.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WsZej-0003tR-O7 for xen-devel@lists.xenproject.org; Thu, 05 Jun 2014 15:32:41 +0000 In-Reply-To: <1401981984.15729.140.camel@hastur.hellion.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian Jackson List-Id: xen-devel@lists.xenproject.org On 05/06/14 17:26, Ian Campbell wrote: > On Mon, 2014-06-02 at 17:08 +0200, Roger Pau Monne wrote: >> +# Parameters: >> +# $1: xenstore backend path of the vif >> +# $2: action, either "add" or "remove" > > On Linux path ($1) is in $XENBUS_PATH and action ($2) is the first > parameter. Does libxl really call the hotplug scripts in a platform > specific manner? Yes, hotplug scripts are platform dependant, the arguments/env variables are set in libxl_{linux/netbsd/freebsd}.c, although I wouldn't mind changing the order, it seems more natural to have the action first and then the backend path IMHO. Roger.