From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH v2 01/17] configure: make the libaio test conditional on blktap1
Date: Thu, 5 Jun 2014 17:49:09 +0200 [thread overview]
Message-ID: <53909175.6060106@citrix.com> (raw)
In-Reply-To: <1401980789.15729.130.camel@hastur.hellion.org.uk>
On 05/06/14 17:06, Ian Campbell wrote:
> On Mon, 2014-06-02 at 17:08 +0200, Roger Pau Monne wrote:
>> libaio is only required for blktap1, so make the check conditional on
>> whether the user has requested blktap1 or not.
>
> I think it is used for blktap2 as well.
OK, I have such a mess with blktap versions and which ones are inside of
the tree. Right now configure only allows enabling/disabling blktap1,
and blktap2 is compiled depending on the host OS version. Should I
change blktap2 to be selected on configure and disabled by default?
(just like blktap1)
> I thought blktap2 was Linux specific (and hence that the libaio could be
> too) but, from tools/Makefile:
> SUBDIRS-$(CONFIG_Linux) += blktap2
> SUBDIRS-$(CONFIG_NetBSD) += blktap2
>
> I'm totally surprised by that! And TBH I find it a little hard to
> believe...
Yes, this is certainly a mistake, NetBSD never had anything similar to
blktap2 AFAIK.
Roger.
next prev parent reply other threads:[~2014-06-05 15:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 15:08 [PATCH v2 00/17] tools: add support for FreeBSD Roger Pau Monne
2014-06-02 15:08 ` [PATCH v2 01/17] configure: make the libaio test conditional on blktap1 Roger Pau Monne
2014-06-05 15:06 ` Ian Campbell
2014-06-05 15:49 ` Roger Pau Monné [this message]
2014-06-06 9:35 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 02/17] configure: disable qemu-trad on FreeBSD systems by default Roger Pau Monne
2014-06-05 15:07 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 03/17] configure: disable ROMBIOS if qemu-trad is disabled Roger Pau Monne
2014-06-05 15:09 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 04/17] include: import FreeBSD headers for evtchn and privcmd devices Roger Pau Monne
2014-06-02 15:08 ` [PATCH v2 05/17] libxc: add support for FreeBSD Roger Pau Monne
2014-06-05 15:11 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 06/17] libxc: remove broken endianess gate on lz4 decompressor Roger Pau Monne
2014-06-05 15:14 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 07/17] xenstored: unify xenstored OS-specific bits Roger Pau Monne
2014-06-05 15:19 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 08/17] xenstored: add FreeBSD xenstored device paths Roger Pau Monne
2014-06-05 15:20 ` Ian Campbell
2014-06-06 9:15 ` Roger Pau Monné
2014-06-06 9:36 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 09/17] console: add FreeBSD includes Roger Pau Monne
2014-06-05 15:20 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 10/17] init: add FreeBSD xencommons init script Roger Pau Monne
2014-06-05 15:24 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 11/17] hotplug: add FreeBSD vif-bridge Roger Pau Monne
2014-06-05 15:26 ` Ian Campbell
2014-06-05 15:32 ` Roger Pau Monné
2014-06-05 15:34 ` Ian Campbell
2014-06-05 15:36 ` Roger Pau Monné
2014-06-02 15:08 ` [PATCH v2 12/17] libxl: add FreeBSD OS support Roger Pau Monne
2014-06-05 15:33 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 13/17] libxl: add support for FreeBSD uuid implementation Roger Pau Monne
2014-06-05 15:39 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 14/17] libxl: only include utmp.h if it's present Roger Pau Monne
2014-06-02 15:08 ` [PATCH v2 15/17] libxl: allow usage of char devices as block backends Roger Pau Monne
2014-06-05 15:41 ` Ian Campbell
2014-06-05 15:44 ` Roger Pau Monné
2014-06-05 15:45 ` Ian Campbell
2014-06-02 15:08 ` [PATCH v2 16/17] hvmloader: remove size_t typedef and include stddef.h Roger Pau Monne
2014-06-02 15:08 ` [PATCH v2 17/17] build: export linker emulation parameter to SeaBIOS Roger Pau Monne
2014-06-05 15:42 ` Ian Campbell
2014-06-18 16:41 ` [PATCH v2 00/17] tools: add support for FreeBSD Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53909175.6060106@citrix.com \
--to=roger.pau@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.