From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3] xen: fix reboot/shutdown with running
 HVM guests
Date: Thu, 5 Jun 2014 17:16:28 +0100
Message-ID: <539097DC.4060007@citrix.com>
References: <1401980484-47815-1-git-send-email-roger.pau@citrix.com>
	<539090DD.2040700@citrix.com>
	<5390B0A6020000780001861F@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1WsaLB-0008LH-PL
	for xen-devel@lists.xenproject.org; Thu, 05 Jun 2014 16:16:33 +0000
In-Reply-To: <5390B0A6020000780001861F@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>, KeirFraser <keir@xen.org>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Eddie Dong <eddie.dong@intel.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jun Nakajima <jun.nakajima@intel.com>, xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 05/06/14 17:02, Jan Beulich wrote:
>>>> On 05.06.14 at 17:46, <andrew.cooper3@citrix.com> wrote:
>> On 05/06/14 16:01, Roger Pau Monne wrote:
>>> If there's a guest using VMX/SVM when the hypervisor shuts down, it
>>> can lead to the following crash due to VMX/SVM functions being called
>>> after hvm_cpu_down has been called. In order to prevent that, check in
>>> {svm/vmx}_ctxt_switch_from that the cpu virtualization extensions are
>>> still enabled.
>> I feel that this is still trying to fix the problem from the wrong end. 
>> It is incorrect to be in a context switch at the point identified in the
>> stack trace.
>>
>> How about having the hvm_cpu_down functions look at current, and
>> optionally run sync_exec_state() ?
> I considered this too before suggesting the other alternative,
> but why would getting into the context switch path this way
> be any better than through map_domain_page()?
>
> Jan
>

It is a more controlled point on all shutdown/crash paths, but still not
perfect.

What we probably need on all shutdown paths is an early step of
"reschedule the idle vcpu back on all pcpus".  This won't fix the issue
for crash paths however.

~Andrew