From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsniw-00056M-8P for qemu-devel@nongnu.org; Fri, 06 Jun 2014 02:34:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wsniq-0001jG-BV for qemu-devel@nongnu.org; Fri, 06 Jun 2014 02:33:58 -0400 Received: from mail-pb0-f43.google.com ([209.85.160.43]:40122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wsniq-0001jA-5o for qemu-devel@nongnu.org; Fri, 06 Jun 2014 02:33:52 -0400 Received: by mail-pb0-f43.google.com with SMTP id up15so2239574pbc.16 for ; Thu, 05 Jun 2014 23:33:50 -0700 (PDT) Message-ID: <539160C9.9070107@ozlabs.ru> Date: Fri, 06 Jun 2014 16:33:45 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <53913773.5040702@ozlabs.ru> <87a99qr1r7.fsf@blackfin.pond.sub.org> In-Reply-To: <87a99qr1r7.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] checkpatch.pl question List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: "qemu-devel@nongnu.org" On 06/06/2014 04:27 PM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> Hi! >> >> checkpatch.pl often complains on things like this: >> >> === >> ERROR: need consistent spacing around '*' (ctx:WxV) >> #57: FILE: hw/misc/vfio.c:4323: >> +int vfio_container_ioctl(AddressSpace *as, int32_t groupid, >> ^ >> >> total: 1 errors, 0 warnings, 46 lines checked >> === >> >> Since perl is a write-only language, I cannot understand why :) Any clue? > > It misinterprets the '*' as infix operator, because it doesn't recognize > 'AddressSpace *as' is a declaration. Sorry, this isn't much of a clue, > but you didn't provide much of a reproducer. > Ooops. Sorry about that. The failing patch has been posted today: [PATCH v8 2/4] vfio: Add vfio_container_ioctl() And the failing chunk is: diff --git a/include/hw/misc/vfio.h b/include/hw/misc/vfio.h new file mode 100644 index 0000000..0b26cd8 --- /dev/null +++ b/include/hw/misc/vfio.h @@ -0,0 +1,9 @@ +#ifndef VFIO_API_H +#define VFIO_API_H + +#include "qemu/typedefs.h" + +extern int vfio_container_ioctl(AddressSpace *as, int32_t groupid, + int req, void *param); + +#endif -- Alexey