From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hongyang Yang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH v10 5/5] libxl: network buffering cmdline
	switch
Date: Fri, 6 Jun 2014 14:34:00 +0800
Message-ID: <539160D8.9020900@cn.fujitsu.com>
References: <1401932069-16460-1-git-send-email-yanghy@cn.fujitsu.com>	<1401932069-16460-6-git-send-email-yanghy@cn.fujitsu.com>
	<21392.43321.897318.194313@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21392.43321.897318.194313@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: ian.campbell@citrix.com, wency@cn.fujitsu.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca, roger.pau@citrix.com, laijs@cn.fujitsu.com
List-Id: xen-devel@lists.xenproject.org

On 06/06/2014 01:30 AM, Ian Jackson wrote:
> Yang Hongyang writes ("[PATCH v10 5/5] libxl: network buffering cmdline switch"):
>> Command line switch to 'xl remus' command, to enable network buffering.
>> Pass on this flag to libxl so that it can act accordingly.
>
> You provide a global option to control the script, but no per-domain
> config option.  Why ?
>
> A similar question arises about the network buffering boolean.
>
> Wouldn't it be better if these were options on the devices, in the
> domain configuration ?

Do you mean we make "-n -N" options into domain configuration?
I think these options are only related to remus and may not be used that
often because we provided a default network script which would be suitable
for most cases. these options are sort of second choices for users, may not
worth to be set in the domain configuration.

>
> Feel free to tell me I'm wrong and it is better this way, if that's
> true - just explain it.
>
>> +     * TODO: Split-Brain check.
>
> What are your plans for the split brain check ?

It's hard to do the split brain check under current implementation because
there's only one remus connection between the two domain. We may need to add
a heardbeat module to do this.

>
> Thanks,
> Ian.
> .
>

-- 
Thanks,
Yang.