From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Alexei Starovoitov <ast@plumgrid.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: filter: fix typo in sparc BPF JIT
Date: Fri, 06 Jun 2014 18:11:19 +0400 [thread overview]
Message-ID: <5391CC07.4000002@cogentembedded.com> (raw)
In-Reply-To: <1402033664-14551-1-git-send-email-ast@plumgrid.com>
Hello.
On 06/06/2014 09:47 AM, Alexei Starovoitov wrote:
> fix typo in sparc codegen for SKF_AD_IFINDEX and SKF_AD_HATYPE
> classic BPF extensions
> Fixes: 2809a2087cc4 ("net: filter: Just In Time compiler for sparc")
> Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
> ---
> tested with qemu-sparc64
> the patch doesn't apply cleanly to net-next, but logic is the same.
> arch/sparc/net/bpf_jit_comp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> diff --git a/arch/sparc/net/bpf_jit_comp.c b/arch/sparc/net/bpf_jit_comp.c
> index a82c6b2..b19a0c2 100644
> --- a/arch/sparc/net/bpf_jit_comp.c
> +++ b/arch/sparc/net/bpf_jit_comp.c
> @@ -83,9 +83,9 @@ static void bpf_flush_icache(void *start_, void *end_)
> #define BNE (F2(0, 2) | CONDNE)
>
> #ifdef CONFIG_SPARC64
> -#define BNE_PTR (F2(0, 1) | CONDNE | (2 << 20))
> +#define BE_PTR (F2(0, 1) | CONDE | (2 << 20))
> #else
> -#define BNE_PTR BNE
> +#define BE_PTR BNE
BNE, not BE?
WBR, Sergei
prev parent reply other threads:[~2014-06-06 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 5:47 [PATCH net] net: filter: fix typo in sparc BPF JIT Alexei Starovoitov
2014-06-06 7:47 ` David Miller
2014-06-06 8:36 ` David Laight
2014-06-06 15:27 ` Alexei Starovoitov
2014-06-06 14:11 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5391CC07.4000002@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.