From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals around g_free()
Date: Fri, 06 Jun 2014 11:02:23 -0600 [thread overview]
Message-ID: <5391F41F.4090407@redhat.com> (raw)
In-Reply-To: <1402073264-9606-2-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On 06/06/2014 10:47 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> ui/vnc-tls.c | 6 ++----
> ui/vnc.c | 12 ++++--------
> 2 files changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c
> index 50275de..6392326 100644
> --- a/ui/vnc-tls.c
> +++ b/ui/vnc-tls.c
> @@ -443,10 +443,8 @@ static int vnc_set_x509_credential(VncDisplay *vd,
> {
> struct stat sb;
>
> - if (*cred) {
> - g_free(*cred);
> - *cred = NULL;
> - }
> + g_free(*cred);
> + *cred = NULL;
>
> *cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
Still a dead store
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-06-06 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 16:47 [Qemu-devel] [PATCH v2 0/2] vnc: Drop some superfluous conditionals Markus Armbruster
2014-06-06 16:47 ` [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals around g_free() Markus Armbruster
2014-06-06 17:02 ` Eric Blake [this message]
2014-06-06 17:11 ` Markus Armbruster
2014-06-10 8:03 ` Gerd Hoffmann
2014-06-06 16:47 ` [Qemu-devel] [PATCH v2 2/2] vnc: Drop superfluous conditionals around g_strdup() Markus Armbruster
2014-06-06 17:03 ` Eric Blake
2014-06-12 11:40 ` [Qemu-devel] [PATCH v2 0/2] vnc: Drop some superfluous conditionals Gerd Hoffmann
2014-06-12 12:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5391F41F.4090407@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.