Re: [PATCH] mingw: redefine the wrapper macro after the corresponding function

[Karsten Blees <karsten.blees@gmail.com>]

Am 06.06.2014 13:10, schrieb Stepan Kasal:
> Hi Karsten,
> 
> On Fri, Jun 06, 2014 at 11:43:03AM +0200, Karsten Blees wrote:
>> Thinking about this some more, the best solution is probably to
>> eliminate the problem altogether by adding inline-wrappers for
>> required CRT-functions, e.g.:
> 
> Yes, this is acceptable.  But I wouldn't pollute mingw.h.  You can do
> it on top of mingw.c like this:

But having it in the .h file may come in handy if we want to split the overlong mingw.c into several compilation units...

> 
> #undef gethostname
> static inline int crt_gethostname(char *host, int namelen)
> {
> 	return gethostname(host, namelen);
> }
> #define gethostname please_call_the_mingw_or_crt_version
> 

Now you're mixing all three variants...note that with my suggestion to #define crt_foo in mingw.h, you don't need '#undef foo', nor redefine foo (your variant), nor rename other callers in mingw.c to 'mingw_foo' (Hannes' variant).

Callers of foo() would simply write "foo()", no matter whether in mingw.c or anywhere else. In the special case that you really want the CRT version, you'd write crt_foo(). This works everywhere, even in core-git code wrapped in #ifdef GIT_WINDOWS_NATIVE.

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.