From: Jens Axboe <axboe@kernel.dk>
To: Sam Bradshaw <sbradshaw@micron.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtip32xx: minor performance enhancements
Date: Fri, 06 Jun 2014 12:55:57 -0600 [thread overview]
Message-ID: <53920EBD.1010209@kernel.dk> (raw)
In-Reply-To: <53921024.6080808@micron.com>
On 06/06/2014 01:01 PM, Sam Bradshaw wrote:
> This patch adds the following:
>
> 1) Compiler hinting in the fast path.
> 2) A prefetch of port->flags to eliminate moderate cpu stalling later
> in mtip_hw_submit_io().
> 3) Eliminate a redundant rq_data_dir().
> 4) Reorder members of driver_data to eliminate false cacheline sharing
> between irq_workers_active and unal_qdepth.
>
> With some workload and topology configurations, I'm seeing ~1.5%
> throughput improvement in small block random read benchmarks as well
> as improved latency std. dev.
Seems I got a small bump in peak perf as well. In any case, it's
innocuous, so should do no harm to apply.
--
Jens Axboe
prev parent reply other threads:[~2014-06-06 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 19:01 [PATCH] mtip32xx: minor performance enhancements Sam Bradshaw
2014-06-06 18:55 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53920EBD.1010209@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sbradshaw@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.