From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH] KVM: Fix GSI number space limit Date: Sat, 07 Jun 2014 02:31:37 +0200 Message-ID: <53925D69.8020404@suse.de> References: <1402058765-48921-1-git-send-email-agraf@suse.de> <5391ECD2.3060507@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Paolo Bonzini , qemu-devel@nongnu.org Return-path: Received: from cantor2.suse.de ([195.135.220.15]:34858 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752527AbaFGAbk (ORCPT ); Fri, 6 Jun 2014 20:31:40 -0400 In-Reply-To: <5391ECD2.3060507@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06.06.14 18:31, Paolo Bonzini wrote: > Il 06/06/2014 14:46, Alexander Graf ha scritto: >> KVM tells us the number of GSIs it can handle inside the kernel. That >> value is >> basically KVM_MAX_IRQ_ROUTES. However when we try to set the GSI >> mapping table, >> it checks for >> >> r = -EINVAL; >> if (routing.nr >= KVM_MAX_IRQ_ROUTES) >> goto out; >> >> erroring out even when we're only using all of the GSIs. To make sure >> we never >> hit that limit, let's reduce the number of GSIs we get from KVM by one. >> >> Signed-off-by: Alexander Graf >> --- >> kvm-all.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kvm-all.c b/kvm-all.c >> index 4e19eff..56a251b 100644 >> --- a/kvm-all.c >> +++ b/kvm-all.c >> @@ -938,7 +938,7 @@ void kvm_init_irq_routing(KVMState *s) >> { >> int gsi_count, i; >> >> - gsi_count = kvm_check_extension(s, KVM_CAP_IRQ_ROUTING); >> + gsi_count = kvm_check_extension(s, KVM_CAP_IRQ_ROUTING) - 1; >> if (gsi_count > 0) { >> unsigned int gsi_bits, i; >> >> > > Applied, thanks! Please CC this to qemu-stable when you send it out :). Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wt4Xy-0006kV-BQ for qemu-devel@nongnu.org; Fri, 06 Jun 2014 20:31:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wt4Xr-0008Qi-Pf for qemu-devel@nongnu.org; Fri, 06 Jun 2014 20:31:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46926 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wt4Xr-0008Qb-IK for qemu-devel@nongnu.org; Fri, 06 Jun 2014 20:31:39 -0400 Message-ID: <53925D69.8020404@suse.de> Date: Sat, 07 Jun 2014 02:31:37 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1402058765-48921-1-git-send-email-agraf@suse.de> <5391ECD2.3060507@redhat.com> In-Reply-To: <5391ECD2.3060507@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] KVM: Fix GSI number space limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: kvm@vger.kernel.org On 06.06.14 18:31, Paolo Bonzini wrote: > Il 06/06/2014 14:46, Alexander Graf ha scritto: >> KVM tells us the number of GSIs it can handle inside the kernel. That >> value is >> basically KVM_MAX_IRQ_ROUTES. However when we try to set the GSI >> mapping table, >> it checks for >> >> r = -EINVAL; >> if (routing.nr >= KVM_MAX_IRQ_ROUTES) >> goto out; >> >> erroring out even when we're only using all of the GSIs. To make sure >> we never >> hit that limit, let's reduce the number of GSIs we get from KVM by one. >> >> Signed-off-by: Alexander Graf >> --- >> kvm-all.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kvm-all.c b/kvm-all.c >> index 4e19eff..56a251b 100644 >> --- a/kvm-all.c >> +++ b/kvm-all.c >> @@ -938,7 +938,7 @@ void kvm_init_irq_routing(KVMState *s) >> { >> int gsi_count, i; >> >> - gsi_count = kvm_check_extension(s, KVM_CAP_IRQ_ROUTING); >> + gsi_count = kvm_check_extension(s, KVM_CAP_IRQ_ROUTING) - 1; >> if (gsi_count > 0) { >> unsigned int gsi_bits, i; >> >> > > Applied, thanks! Please CC this to qemu-stable when you send it out :). Alex