From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: davem@davemloft.net, stephen@networkplumber.org,
netdev@vger.kernel.org, wkok@cumulusnetworks.com,
sfeldma@cumulusnetworks.com, shm@cumulusnetworks.com,
Vlad Yasevich <vyasevic@redhat.com>
Subject: Re: [PATCH iproute2 v3] bridge: Add master device name to bridge fdb show
Date: Sun, 08 Jun 2014 11:24:13 -0400 [thread overview]
Message-ID: <5394801D.6080704@mojatatu.com> (raw)
In-Reply-To: <539476D7.8020300@cumulusnetworks.com>
On 06/08/14 10:44, Roopa Prabhu wrote:
> sure, you seemed to be using my below patch in your examples for fdb
> filtering.
> so thought i should resubmit. I am now ok with either.
Yes, my patch is on top of your earlier (version 1) patch. I preferred
that version.
I looked at the code a little more after sending that email.
There is some value in displaying a bridge port's unicast addresses
and even setting them; but only in the case that the bridge port is
itself an owner of an fdb. As an example of such a case when you have
another bridge attached to a bridge as a port; or when you have
something like a vxlan as a bridge port etc.
However, current code does not discriminate. I cant make sense of
why this would be intentional but possibly i am missing some use cases.
cheers,
jamal
next prev parent reply other threads:[~2014-06-08 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-08 5:23 [PATCH iproute2 v3] bridge: Add master device name to bridge fdb show roopa
2014-06-08 11:24 ` Jamal Hadi Salim
2014-06-08 14:44 ` Roopa Prabhu
2014-06-08 15:24 ` Jamal Hadi Salim [this message]
2014-06-08 22:25 ` Roopa Prabhu
2014-06-09 10:21 ` Jamal Hadi Salim
2014-06-09 19:56 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5394801D.6080704@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@cumulusnetworks.com \
--cc=shm@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
--cc=wkok@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.