All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Chen Gang <gang.chen.5i5j@gmail.com>,
	quintela@redhat.com,  arei.gonglei@huawei.com,
	Eric Blake <eblake@redhat.com>,
	 dgilbert@redhat.com, owasserm@redhat.com
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH-trivial] arch_init.c: Free 'cache' in cache_fini() to avoid memory leak
Date: Sun, 08 Jun 2014 21:53:13 +0400	[thread overview]
Message-ID: <5394A309.2010808@msgid.tls.msk.ru> (raw)
In-Reply-To: <538C6B37.2030400@gmail.com>

02.06.2014 16:16, Chen Gang wrote:
> Call g_free() after cache_fini() in migration_end(), but do not call
> g_free() after call cache_fini() in xbzrle_cache_resize() which will
> cause memory leak.
> 
> cache_init() and cache_fini() are pair, so need let cache_fini() call
> g_free(cache) to match cache_init(), then fix current issue too.

Applied to -trivial, with the following commit message:

migration: Plug memory leak in migrate-set-cache-size command

We call g_free() after cache_fini() in migration_end(), but we don't
call it after cache_fini() in xbzrle_cache_resize(), leaking the
memory.

cache_init() and cache_fini() are a pair.  Since cache_init()
allocates the cache, let cache_fini() free it.  This plugs the leak.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Chen Gang <gang.chen.5i5j@gmail.com>,
	quintela@redhat.com, arei.gonglei@huawei.com,
	Eric Blake <eblake@redhat.com>,
	dgilbert@redhat.com, owasserm@redhat.com
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH-trivial] arch_init.c: Free 'cache' in cache_fini() to avoid memory leak
Date: Sun, 08 Jun 2014 21:53:13 +0400	[thread overview]
Message-ID: <5394A309.2010808@msgid.tls.msk.ru> (raw)
In-Reply-To: <538C6B37.2030400@gmail.com>

02.06.2014 16:16, Chen Gang wrote:
> Call g_free() after cache_fini() in migration_end(), but do not call
> g_free() after call cache_fini() in xbzrle_cache_resize() which will
> cause memory leak.
> 
> cache_init() and cache_fini() are pair, so need let cache_fini() call
> g_free(cache) to match cache_init(), then fix current issue too.

Applied to -trivial, with the following commit message:

migration: Plug memory leak in migrate-set-cache-size command

We call g_free() after cache_fini() in migration_end(), but we don't
call it after cache_fini() in xbzrle_cache_resize(), leaking the
memory.

cache_init() and cache_fini() are a pair.  Since cache_init()
allocates the cache, let cache_fini() free it.  This plugs the leak.

Thanks,

/mjt

  parent reply	other threads:[~2014-06-08 17:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02 12:16 [Qemu-trivial] [PATCH-trivial] arch_init.c: Free 'cache' in cache_fini() to avoid memory leak Chen Gang
2014-06-02 12:16 ` [Qemu-devel] " Chen Gang
2014-06-03  7:17 ` [Qemu-trivial] " ChenLiang
2014-06-03  7:17   ` ChenLiang
2014-06-04  8:16 ` [Qemu-trivial] " Markus Armbruster
2014-06-04  8:16   ` Markus Armbruster
2014-06-04 10:28   ` [Qemu-trivial] " Chen Gang
2014-06-04 10:28     ` Chen Gang
2014-06-04 10:54     ` [Qemu-trivial] " Markus Armbruster
2014-06-04 10:54       ` Markus Armbruster
2014-06-04 11:30       ` [Qemu-trivial] " Chen Gang
2014-06-04 11:30         ` Chen Gang
2014-06-04  9:35 ` [Qemu-trivial] " Dr. David Alan Gilbert
2014-06-04  9:35   ` Dr. David Alan Gilbert
2014-06-08 17:53 ` Michael Tokarev [this message]
2014-06-08 17:53   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5394A309.2010808@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=arei.gonglei@huawei.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=owasserm@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.