All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao feng <gaofeng@cn.fujitsu.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
	Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next] net: force a list_del() in unregister_netdevice_many()
Date: Mon, 9 Jun 2014 09:27:24 +0800	[thread overview]
Message-ID: <53950D7C.5060001@cn.fujitsu.com> (raw)
In-Reply-To: <1402062243.3645.295.camel@edumazet-glaptop2.roam.corp.google.com>

On 06/06/2014 09:44 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> unregister_netdevice_many() API is error prone and we had too
> many bugs because of dangling LIST_HEAD on stacks.
> 
> See commit f87e6f47933e3e ("net: dont leave active on stack LIST_HEAD")
> 
> In fact, instead of making sure no caller leaves an active list_head,
> just force a list_del() in the callee. No one seems to need to access
> the list after unregister_netdevice_many()
> 

Just like the patch I posted one year ago, interesting :)
http://patchwork.ozlabs.org/patch/223521/

  parent reply	other threads:[~2014-06-09  1:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04  0:11 [Patch net-next] net: remove some unless free on failure in alloc_netdev_mqs() Cong Wang
2014-06-04  0:11 ` [Patch net-next] net: remove some useless list_del() Cong Wang
2014-06-04  0:24   ` David Miller
2014-06-04  0:43   ` Eric Dumazet
2014-06-04  2:18     ` Alexei Starovoitov
2014-06-04  8:26       ` Daniel Borkmann
2014-06-06  6:40     ` Cong Wang
2014-06-06 13:17       ` Eric Dumazet
2014-06-06 13:44         ` [PATCH net-next] net: force a list_del() in unregister_netdevice_many() Eric Dumazet
2014-06-06 15:54           ` Alexei Starovoitov
2014-06-08 21:15           ` David Miller
2014-06-09  1:27           ` Gao feng [this message]
2014-06-09  5:48             ` Eric Dumazet
2014-06-09  5:58         ` [Patch net-next] net: remove some useless list_del() Cong Wang
2014-06-04  2:19 ` [Patch net-next] net: remove some unless free on failure in alloc_netdev_mqs() David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53950D7C.5060001@cn.fujitsu.com \
    --to=gaofeng@cn.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.