All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: blk-exec.c:  Cleaning up local variable address returnd
Date: Sun, 08 Jun 2014 19:50:37 -0600	[thread overview]
Message-ID: <539512ED.1000203@kernel.dk> (raw)
In-Reply-To: <1402094247-7998-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

On 2014-06-06 16:37, Rickard Strandqvist wrote:
> Address of local variable assigned to a function parameter
>
> This was partly found using a static code analysis program called cppcheck.

I'd be surprised if this was a real bug, but I agree on principle, we 
should not leak stack data. The code is in place since for drivers that 
rely on sense always being available. I will apply, thanks.

-- 
Jens Axboe


      reply	other threads:[~2014-06-09  1:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06 22:37 [PATCH] block: blk-exec.c: Cleaning up local variable address returnd Rickard Strandqvist
2014-06-09  1:50 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539512ED.1000203@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rickard_strandqvist@spectrumdigital.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.