Re: [PATCH] ARM: dts: Add missing clock/pin-control entries for I2S0 on Exynos4

[Tushar Behera <trblinux@gmail.com>]

On 06/09/2014 03:23 PM, Sylwester Nawrocki wrote:
> Hi Tushar,
> 
> On 07/06/14 11:30, Tushar Behera wrote:
>> I2S driver uses 3 clocks under different conditions. Added two
>> missing clocks.
>>
>> Additionally updated pin-control property for this node.
>>
>> Signed-off-by: Tushar Behera <tushar.b@samsung.com>
>> ---
>> Based on next-20140606.
>>
>> Tested on Exynos4210-based Origen boards with private patches for
>> codec/machine driver.
>>
>>  arch/arm/boot/dts/exynos4.dtsi |    8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index fbaf426..10bb081 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -55,11 +55,15 @@
>>  	i2s0: i2s@03830000 {
>>  		compatible = "samsung,s5pv210-i2s";
>>  		reg = <0x03830000 0x100>;
>> -		clocks = <&clock_audss EXYNOS_I2S_BUS>;
>> -		clock-names = "iis";
>> +		clocks = <&clock_audss EXYNOS_I2S_BUS>,
>> +			<&clock_audss EXYNOS_I2S_BUS>,
>> +			<&clock_audss EXYNOS_SCLK_I2S>;
>> +		clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
>>  		dmas = <&pdma0 12>, <&pdma0 11>, <&pdma0 10>;
>>  		dma-names = "tx", "rx", "tx-sec";
>>  		samsung,idma-addr = <0x03000000>;
>> +		pinctrl-0 = <&i2s0_bus>;
>> +		pinctrl-names = "default";
>>  		status = "disabled";
>>  	};
> 
> I assumed those properties you're adding here belong to board or
> to SoC type specific dts. It doesn't hurt ot have it like this,
> but what do you think about moving this to  arch/arm/boot/dts/
> exynos4210(4x12).dtsi ? For instance pinctrl definitions are
> in SoC specific dts.
> 

IMHO, the clock entries belong here as the audss clock provider
essentially remains same for all Exynos4 based systems.

As for pin-control entry, I believe we can move them to respective SoC
dtsi files.

Does that sound okay to you?

> --
> Thanks,
> Sylwester
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
Tushar Behera