From: Loic Dachary <loic@dachary.org>
To: Zack Cerza <zack.cerza@inktank.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: teuthology and erasure code pool creation
Date: Mon, 09 Jun 2014 19:27:54 +0200 [thread overview]
Message-ID: <5395EE9A.2030800@dachary.org> (raw)
In-Reply-To: <CAMfdg1PhTWuL1LKCZuOV5GwhNMehsY1HNeBPtWkJwy01_7Q42g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2015 bytes --]
On 09/06/2014 19:15, Zack Cerza wrote:
> Hi Loic,
>
> Without spending too much time investigating, it seems to me it would
> be preferable to just add the missing arguments to the functions you
> pointed out. That way they could even be fully documented! ;)
Ok, I'll do that, thanks !
>
> Zack
>
> On Sun, Jun 8, 2014 at 11:00 AM, Loic Dachary <loic@dachary.org> wrote:
>> Hi Zack,
>>
>> In order to test locally repairable codes ( described at https://wiki.ceph.com/Planning/Blueprints/Giant/Pyramid_Erasure_Code and documented at https://github.com/dachary/ceph/commit/2ae645438243232392c11fd80fd960f6221fd2a0#diff-5518964bc98a094a784ce2d17a5b0cc1R20 ) it would be a convenient to set the erasure code profile without modifying the teuthology code.
>>
>> There are not too many instances of hardcoded parameters:
>>
>> https://github.com/ceph/teuthology/blob/master/teuthology/task_util/rados.py#L27
>> https://github.com/ceph/teuthology/blob/master/teuthology/task/ceph_manager.py#L732
>>
>> and it could be generalized. In a nutshell, the definition of an erasure coded profile is a set of key value which should default to:
>>
>> k: 2
>> m: 1
>> plugin: jerasure
>> ruleset-failure-domain: osd
>>
>> and
>>
>> self.raw_cluster_cmd('osd', 'erasure-code-profile', 'set', 'teuthologyprofile', 'ruleset-failure-domain=osd', 'm='+str(ec_m), 'k='+str(ec_k))
>>
>> could be replaced with:
>>
>> self.raw_cluster_cmd('osd', 'erasure-code-profile', 'set', 'teuthologyprofile', **kwargs)
>>
>> assuming kwargs is the above map parsed from the yaml.
>>
>> Any advice you may have on the implementation would be very welcome :-)
>>
>> Cheers
>> --
>> Loïc Dachary, Artisan Logiciel Libre
>>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Loïc Dachary, Artisan Logiciel Libre
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2014-06-09 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-08 16:00 teuthology and erasure code pool creation Loic Dachary
2014-06-09 17:15 ` Zack Cerza
2014-06-09 17:27 ` Loic Dachary [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5395EE9A.2030800@dachary.org \
--to=loic@dachary.org \
--cc=ceph-devel@vger.kernel.org \
--cc=zack.cerza@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.