All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Francois Romieu <romieu@fr.zoreil.com>, <netdev@vger.kernel.org>
Cc: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 1/1] amd-xgbe: fix unused variable compilation warning in phylib driver
Date: Mon, 9 Jun 2014 14:07:28 -0500	[thread overview]
Message-ID: <539605F0.9080701@amd.com> (raw)
In-Reply-To: <20140607090748.GA11521@electric-eye.fr.zoreil.com>

On 06/07/2014 04:07 AM, Francois Romieu wrote:
> Fix following compilation warning:
> [...]
>    CC      drivers/net/phy/amd-xgbe-phy.o
> drivers/net/phy/amd-xgbe-phy.c:1353:30: warning:
> ‘amd_xgbe_phy_ids’ defined but not used [-Wunused-variable]
>   static struct mdio_device_id amd_xgbe_phy_ids[] = {
>                                ^
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   drivers/net/phy/amd-xgbe-phy.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/amd-xgbe-phy.c b/drivers/net/phy/amd-xgbe-phy.c
> index d4b1c81..b57c224 100644
> --- a/drivers/net/phy/amd-xgbe-phy.c
> +++ b/drivers/net/phy/amd-xgbe-phy.c
> @@ -1350,7 +1350,7 @@ static void __exit amd_xgbe_phy_exit(void)
>   module_init(amd_xgbe_phy_init);
>   module_exit(amd_xgbe_phy_exit);
>
> -static struct mdio_device_id amd_xgbe_phy_ids[] = {
> +static struct mdio_device_id __maybe_unused amd_xgbe_phy_ids[] = {
>   	{ XGBE_PHY_ID, XGBE_PHY_MASK },
>   	{ }
>   };
>

  reply	other threads:[~2014-06-09 19:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-07  9:07 [PATCH net-next 1/1] amd-xgbe: fix unused variable compilation warning in phylib driver Francois Romieu
2014-06-09 19:07 ` Tom Lendacky [this message]
2014-06-11  7:15 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539605F0.9080701@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.