All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Allen Schade <aschade@google.com>, fio@vger.kernel.org
Subject: Re: unable to replay a trace generated w/ fio
Date: Mon, 09 Jun 2014 19:57:28 -0600	[thread overview]
Message-ID: <53966608.1070309@kernel.dk> (raw)
In-Reply-To: <53966518.6020407@kernel.dk>

On 2014-06-09 19:53, Jens Axboe wrote:
> On 2014-06-05 13:02, Allen Schade wrote:
>> Jens Axboe <axboe@...> writes:
>>
>>>
>>> On 2014-05-18 04:01, Alket Memushaj wrote:
>>>> I am not having luck with 2.1.7 either, but anything up to 2.0.11
>>>> works. It seems to terminate as soon as it completes reading the trace
>>>> file - at the end of which I have /dev/sdb close as that's what's
>>>> generated by fio itself when I set write_iolog=<file>
>>>
>>> I'll take a look, I bet it's an issue from around the time the file
>>> opening logic was added.
>>>
>>> Can you send the exact job you used to create and replay files? Will
>>> make my life easier.
>>>
>>
>> Hi, I'm am running into this issue too.
>>
>> Here are simple instructions to replicate:
>>
>> [hdc-write]
>> filename=/dev/hdc
>> ioengine=sync
>> iodepth=1
>> direct=1
>> thread=1
>> continue_on_error=1
>> read_iolog=trace.log
>>
>>
>> trace.log:
>> /dev/hdc add
>> /dev/hdc open
>> /dev/hdc write 2045557202944 8192
>> /dev/hdc close
>>
>> ./fio trace.fio
>> hdc-write: (g=0): rw=read, bs=4K-4K/4K-4K/4K-4K, ioengine=sync, iodepth=1
>> fio-2.1.7
>> Starting 1 thread
>> Segmentation fault (core dumped)
>
> OK, so the replay bug here is that you added a filename=. Due to a bug
> in the freeing of files logic (fio does do that for iolog loads), we
> don't reset this when freeing files. So fio attempts to close 2 files on
> exit, boom.
>
> This is fixed in -git as of now. Replay of that file still looks weird,
> doesn't look like it actually does that IO. Will debug next...

That should be fixed as well now. Can you retry with current -git?

-- 
Jens Axboe



      reply	other threads:[~2014-06-10  1:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-17 11:52 unable to replay a trace generated w/ fio Alket Memushaj
2014-05-17 12:10 ` Alket Memushaj
2014-05-18 10:01   ` Alket Memushaj
2014-05-19 19:47     ` Jens Axboe
2014-06-05 19:02       ` Allen Schade
2014-06-05 20:21         ` Allen Schade
2014-06-10  1:53         ` Jens Axboe
2014-06-10  1:57           ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53966608.1070309@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=aschade@google.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.